Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shim/global.ts to use globalThis #222

Closed
dasa opened this issue Jan 10, 2019 · 2 comments
Closed

Update shim/global.ts to use globalThis #222

dasa opened this issue Jan 10, 2019 · 2 comments
Assignees
@maier49

Comments

@dasa
Copy link
Contributor

dasa commented Jan 10, 2019

Bug

Package Version: 5

Code

Chrome, Safari TP and TS are using globalThis rather than global. See: microsoft/TypeScript#29332 (This PR makes it sound like TS will handle this in the future such that the shim would no longer be needed.)

Expected behavior:

Actual behavior:
@dasa
Copy link
Contributor Author

dasa commented Apr 19, 2019

See: https://mathiasbynens.be/notes/globalthis

@maier49 maier49 mentioned this issue Jul 8, 2019
Merged
3 tasks
@maier49 maier49 self-assigned this Jul 8, 2019
@maier49
Copy link
Contributor

maier49 commented Jul 29, 2019

Resolved by #437

@maier49 maier49 closed this as completed Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maier49 maier49

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dasa @maier49