Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move packages to use BrowserStack #186

Closed
agubler opened this issue May 22, 2017 · 6 comments
Closed

Move packages to use BrowserStack #186

agubler opened this issue May 22, 2017 · 6 comments

Comments

@agubler
Copy link
Member

agubler commented May 22, 2017

Convert remaining Dojo 2 packages that use saucelabs to browserstack.

@kitsonk
Copy link
Member

kitsonk commented Jul 27, 2017

Anything left? If so we should either list in this issue or raises issues in the other repos.

@kitsonk kitsonk added the beta2 label Jul 27, 2017
@dylans
Copy link
Member

dylans commented Jul 29, 2017

Did a quick review of packages that either still use SL or do not have the more recent BrowserStack credentials:

  • - @dojo/app
  • @dojo/cli
  • @dojo/cli-build-webpack
  • @dojo/cli-create-app
  • @dojo/cli-export-project
  • @dojo/cli-test-intern
  • @dojo/interfaces
  • - @dojo/i18n
  • - @dojo/streams

And of course the inactive/deprecated packages:

  • dojo/actions
  • dojo/crypto
  • dojo/dataviz
  • dojo/compose
  • dojo/dom
  • dojo/parser

@dylans dylans modified the milestones: 2017.08, 2017.07 Jul 29, 2017
@kitsonk
Copy link
Member

kitsonk commented Jul 31, 2017

The CLI packages and Interfaces don't get tested on BrowserStack (because they don't run in a browser). We should remove the credentials from them, so as to not confuse.

@kitsonk kitsonk modified the milestones: 2017.08, 2017.09 Sep 4, 2017
@kitsonk kitsonk modified the milestones: 2017.09, 2017.10 Oct 9, 2017
@kitsonk kitsonk added beta4 and removed beta3 labels Oct 9, 2017
@kitsonk
Copy link
Member

kitsonk commented Oct 9, 2017

This is just dross we should focus on clearing out.

@edhager
Copy link

edhager commented Oct 17, 2017

dojo/i18n was converted during the upgrade to Intern 4 (dojo/i18n#94).

dojo/interfaces is not tested remotely.

I was told that dojo/app was being rewritten and should be converted to Intern 4 and BrowserStack. We can create an "Upgrade to Intern 4" ticket in dojo/app if desired.

From @dylans's list, dojo/streams has not been addressed. It has not been converted to Intern 4 and its CI build is still using SauceLabs. This is also true of the deprecated repos.

@kitsonk
Copy link
Member

kitsonk commented Oct 18, 2017

Streams is just "neglected" at the moment until we have a compelling use case to dust it off and maintain it. We should just create an issue about upgrading the testing to Intern 4 and ensuring it is moved to browser stack, but we would schedule it for a future bit and not tie it to this issue or the intern upgrade Epic.

@kitsonk kitsonk modified the milestones: 2017.10, beta.4 Oct 30, 2017
@kitsonk kitsonk closed this as completed Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants