Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: support fully qualified contract name #96

Closed
1 task
glihm opened this issue Dec 22, 2023 · 0 comments · Fixed by #97
Closed
1 task

[Enhancement]: support fully qualified contract name #96

glihm opened this issue Dec 22, 2023 · 0 comments · Fixed by #97

Comments

@glihm
Copy link

glihm commented Dec 22, 2023

Feedback

Currently, when execute is called on the DojoProvider, under the hood only the name of the contract is looked up.

In this issue, the proposal is to also accept a fully qualified contract name to avoid possible clashes. This by detecting if the given name already contains :: at least once.

This will allow those two behaviors

// Lookup only to the last segment of the module path as currently done.
await execute(props.signer, "actions", "spawn", [props.rps]);

// Search for the exact path.
await execute(props.signer, "emojiman::actions::actions", "spawn", [props.rps]);

If the request is accepted, would you be willing to contribute it?

  • Yes I would be willing to contribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant