Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of the CORS extension needed #1

Closed
wolfderechter opened this issue Jun 12, 2023 · 1 comment
Closed

get rid of the CORS extension needed #1

wolfderechter opened this issue Jun 12, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@wolfderechter
Copy link
Collaborator

Trying to avoid having to specify ' --http.corsdomain "*" ' in the l2_execution_engine (geth fork) docker compose and not having to rely on a browser extension to fix the cors.

I already tried web3/web3.js#2559 (comment) but it's outdated and not working anymore.
The plan is running both the node and dashboard on localhost so they should be able to communicate without problems from what I'm reading.
https://geth.ethereum.org/docs/interacting-with-geth/rpc gives a little more info

@wolfderechter wolfderechter added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 12, 2023
@wolfderechter
Copy link
Collaborator Author

Fixed with this commit where we change the node address to that of the websocket address, because the websockets cors is already set to public out of the box

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant