Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-renew and ls after dokku 0.6.x upgrade #65

Closed
sseemayer opened this issue Jun 20, 2016 · 2 comments
Closed

Fix auto-renew and ls after dokku 0.6.x upgrade #65

sseemayer opened this issue Jun 20, 2016 · 2 comments

Comments

@sseemayer
Copy link
Contributor

sseemayer commented Jun 20, 2016

letsencrypt:auto-renew and letsencrypt:ls are broken after #64 changed the way Let's Encrypt certificates are installed to be more compatible with dokku.

The problem is the detection of let's encrypt-secured apps by checking for the server certificate being a symlink into the let's encrypt folder.

This check needs to be replaced with something else since the certificate is now a copy of the certificates, not a symlink. Suggestion would be to use openssl to check for the certificate issuer instead (should support both real LE and the fake CA for testing)

@josegonzalez
Copy link
Member

You could check that the contents are the exact same?

@sseemayer
Copy link
Contributor Author

sseemayer commented Jun 20, 2016

Guess that should work, too.

Edit: Have some real-life responsibilities keeping me from fixing this myself right now but will probably duck back later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants