SQL export for set types with embedded single quotes broken

[zachmu]

dolt sql <<SQL
create table sets (a varchar(10) primary key, b set('one','two','three\'s'));
insert into sets values ('abc', 'one,two'), ('def', 'two,three\'s');
SQL

dolt table export sets -f export.sql
dolt sql < export.sql

Last line breaks because of unescaped quote character.

JSON columns have the same problem, but for embedded double quotes.

[timsehn]

This seems very related to the fix here: dolthub/go-mysql-server#1639

The above is still broken but it seems like it is on the same path.

[macneale4]

We've regressed on this. I can't create a set with a single quote using backslash or double quote encoding.

db5> create table sets (a varchar(10) primary key, b set('one','two','three\'s'));
Error parsing SQL
syntax error at position 42 near 's'
CREATE TABLE a(b set('one','two','three's'))
                                          ^

db5> create table sets (a varchar(10) primary key, b set('one','two','three''s'));
Error parsing SQL
syntax error at position 42 near 's'
CREATE TABLE a(b set('one','two','three's'))
                                          ^

[macneale4]

Also, this seems to be limited to the set datatype, which I'd never heard of until today:

https://dev.mysql.com/doc/refman/8.0/en/set.html

I'm going to guess this is a rarely use feature of mysql, and this is pretty low priority.

[macneale4]

This seems very related to the fix here: dolthub/go-mysql-server#1639

The above is still broken but it seems like it is on the same path.

I doubt this is the case. Seems really set specific. Unassigning from myself since I think this is low priority.