Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sending back max field length metadata in MySQL wire protocol #3893

Closed
fulghum opened this issue Jul 22, 2022 · 0 comments · Fixed by dolthub/go-mysql-server#1134
Closed

Comments

@fulghum
Copy link
Contributor

fulghum commented Jul 22, 2022

The MySQL wire protocol includes metadata about a column's maximum length, which seems to come directly from the maximum display length set when defining a field (e.g. tinyint(1)). Some MySQL drivers expose this information and some applications rely on it (example of casting tinyint(1) to boolean values). Dolt does not seem to populate this metadata for any types currently.

Note that the maximum display lengths are deprecated in the latest version of MySQL and they don't prevent you from storing larger values in the field, but they are still used by some applications.

@fulghum fulghum changed the title Support sending back field length in MySQL wire protocol Support sending back max field length metadata in MySQL wire protocol Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant