MediaWiki needs SHOW ENGINES to return first letter uppercase column names like MySQL

[timsehn]

MediaWiki runs the following SQL on installation.

CREATE TABLE `site_identifiers` (
si_type VARBINARY(32) NOT NULL,
si_key VARBINARY(32) NOT NULL,
si_site INT UNSIGNED NOT NULL,
INDEX si_site (si_site),
INDEX si_key (si_key),
PRIMARY KEY(si_type, si_key)
) ENGINE=, DEFAULT CHARSET=binary

On Dolt, we get the following error:

WARN[0308] error running query connectTime="2024-03-06 15:31:53.160714 -0800 PST m=+308.583663001" connectionDb=media_wiki connectionID=7 error="syntax error at position 327 near 'ENGINE'"

[timsehn]

Looks like this is the result of Dolt not returning anything for the SHOW ENGINES command:

 15:38:06.559811 -0800 PST m=+9.553067251" connectionDb= connectionID=4 query="SHOW /* MysqlInstaller::getEngines */ ENGINES"

[timsehn]

Looks like we return capitalized column names in SHOW ENGINES

tmp/main> show engines;
+--------+---------+------------------------------------------------------------+--------------+-----+------------+
| ENGINE | SUPPORT | COMMENT                                                    | TRANSACTIONS | XA  | SAVEPOINTS |
+--------+---------+------------------------------------------------------------+--------------+-----+------------+
| InnoDB | DEFAULT | Supports transactions, row-level locking, and foreign keys | YES          | YES | YES        |
+--------+---------+------------------------------------------------------------+--------------+-----+------------+

and MySQL return capitalized first letter:

mysql> SHOW /* MysqlInstaller::getEngines */ ENGINES;
+--------------------+---------+----------------------------------------------------------------+--------------+------+------------+
| Engine             | Support | Comment                                                        | Transactions | XA   | Savepoints |
+--------------------+---------+----------------------------------------------------------------+--------------+------+------------+
| MEMORY             | YES     | Hash based, stored in memory, useful for temporary tables      | NO           | NO   | NO         |
| MRG_MYISAM         | YES     | Collection of identical MyISAM tables                          | NO           | NO   | NO         |
| CSV                | YES     | CSV storage engine                                             | NO           | NO   | NO         |
| FEDERATED          | NO      | Federated MySQL storage engine                                 | NULL         | NULL | NULL       |
| PERFORMANCE_SCHEMA | YES     | Performance Schema                                             | NO           | NO   | NO         |
| MyISAM             | YES     | MyISAM storage engine                                          | NO           | NO   | NO         |
| InnoDB             | DEFAULT | Supports transactions, row-level locking, and foreign keys     | YES          | YES  | YES        |
| ndbinfo            | NO      | MySQL Cluster system information storage engine                | NULL         | NULL | NULL       |
| BLACKHOLE          | YES     | /dev/null storage engine (anything you write to it disappears) | NO           | NO   | NO         |
| ARCHIVE            | YES     | Archive storage engine                                         | NO           | NO   | NO         |
| ndbcluster         | NO      | Clustered, fault-tolerant tables                               | NULL         | NULL | NULL       |
+--------------------+---------+----------------------------------------------------------------+--------------+------+------------+
11 rows in set (0.0004 sec)

MediaWiki relies on the casing of these column namess being the same as MySQL:

https://github.com/wikimedia/mediawiki/blob/4c97b4f417dd0887778bef58b2b3f349f0259089/includes/installer/MysqlInstaller.php#L261

[jycor]

some trimmed output from mysql (with --column-type-info)

mysql> select * from information_schema.engines;
Field 1
Name:      `ENGINE`
Org_name:  `ENGINE`
Catalog:   `def`
Database:  `information_schema`
Table:     `engines`
Org_table: `ENGINES`
Type:      String
DbType:    VAR_STRING
Collation: utf8mb4_0900_ai_ci (255)
Length:    192
Decimals:  0
Flags:     NOT_NULL

...

+--------------------+---------+----------------------------------------------------------------+--------------+------+------------+
| ENGINE             | SUPPORT | COMMENT                                                        | TRANSACTIONS | XA   | SAVEPOINTS |
+--------------------+---------+----------------------------------------------------------------+--------------+------+------------+
| MEMORY             | YES     | Hash based, stored in memory, useful for temporary tables      | NO           | NO   | NO         |
| MRG_MYISAM         | YES     | Collection of identical MyISAM tables                          | NO           | NO   | NO         |
| CSV                | YES     | CSV storage engine                                             | NO           | NO   | NO         |
| FEDERATED          | NO      | Federated MySQL storage engine                                 | NULL         | NULL | NULL       |
| PERFORMANCE_SCHEMA | YES     | Performance Schema                                             | NO           | NO   | NO         |
| MyISAM             | YES     | MyISAM storage engine                                          | NO           | NO   | NO         |
| InnoDB             | DEFAULT | Supports transactions, row-level locking, and foreign keys     | YES          | YES  | YES        |
| ndbinfo            | NO      | MySQL Cluster system information storage engine                | NULL         | NULL | NULL       |
| BLACKHOLE          | YES     | /dev/null storage engine (anything you write to it disappears) | NO           | NO   | NO         |
| ARCHIVE            | YES     | Archive storage engine                                         | NO           | NO   | NO         |
| ndbcluster         | NO      | Clustered, fault-tolerant tables                               | NULL         | NULL | NULL       |
+--------------------+---------+----------------------------------------------------------------+--------------+------+------------+
11 rows in set (0.0005 sec)

mysql> show engines;
Field 1
Name:      `Engine`
Org_name:  `ENGINE`
Catalog:   `def`
Database:  `information_schema`
Table:     `ENGINES`
Org_table: `ENGINES`
Type:      String
DbType:    VAR_STRING
Collation: utf8mb4_0900_ai_ci (255)
Length:    192
Decimals:  0
Flags:     NOT_NULL
...
+--------------------+---------+----------------------------------------------------------------+--------------+------+------------+
| Engine             | Support | Comment                                                        | Transactions | XA   | Savepoints |
+--------------------+---------+----------------------------------------------------------------+--------------+------+------------+
| MEMORY             | YES     | Hash based, stored in memory, useful for temporary tables      | NO           | NO   | NO         |
| MRG_MYISAM         | YES     | Collection of identical MyISAM tables                          | NO           | NO   | NO         |
| CSV                | YES     | CSV storage engine                                             | NO           | NO   | NO         |
| FEDERATED          | NO      | Federated MySQL storage engine                                 | NULL         | NULL | NULL       |
| PERFORMANCE_SCHEMA | YES     | Performance Schema                                             | NO           | NO   | NO         |
| MyISAM             | YES     | MyISAM storage engine                                          | NO           | NO   | NO         |
| InnoDB             | DEFAULT | Supports transactions, row-level locking, and foreign keys     | YES          | YES  | YES        |
| ndbinfo            | NO      | MySQL Cluster system information storage engine                | NULL         | NULL | NULL       |
| BLACKHOLE          | YES     | /dev/null storage engine (anything you write to it disappears) | NO           | NO   | NO         |
| ARCHIVE            | YES     | Archive storage engine                                         | NO           | NO   | NO         |
| ndbcluster         | NO      | Clustered, fault-tolerant tables                               | NULL         | NULL | NULL       |
+--------------------+---------+----------------------------------------------------------------+--------------+------+------------+
11 rows in set (0.0005 sec)

Currently, dolt/gms does not distinguish between org_name and name.
The linked PR should fix this issue for this particular table, but it appears there might be more we have to do to completely avoid case-sensitive issue.