Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch with tag collision test #8567

Merged
merged 1 commit into from
Nov 15, 2024
Merged

patch with tag collision test #8567

merged 1 commit into from
Nov 15, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Nov 15, 2024

Tag collisions exists and can lead to false positives.

fulghum
fulghum approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
1eefa4c ok 5937457
version total_tests
1eefa4c 5937457
correctness_percentage
100.0

@jycor jycor merged commit 37985bf into main Nov 15, 2024
34 of 35 checks passed
@jycor jycor deleted the james/patch branch November 15, 2024 21:33
@BrewTestBot BrewTestBot mentioned this pull request Nov 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jycor @coffeegoddd @fulghum