CreateTable: DEFAULT CHARACTER SET missing

[fionera]

When a Query contains a DEFAULT CHARACTER SET or a COLLATE its not available in the CreateTable function

[fulghum]

Hey @fionera, thanks for checking out the go-mysql-server project. @Hydrocharged led the work for charsets and collations, so I'm assigning this one to him to help you out with.

It sounds like you're asking about where the charset/collation info goes after it's parsed, specifically for CreateTable, so that you can switch behavior on that?

[Hydrocharged]

Hi @fionera! If I'm understanding your question correctly, when you use a COLLATE expression, it wraps the target expression in a CollatedExpression. Also, whenever setting a table's collation, it may be found here in the CreateTable node.

[fionera]

Ah Thank you! I wasnt on the main branch and didnt had the Collation yet. Now I am only missing a way to get the DEFAULT CHARACTER SET part of the query.

[zachmu]

@Hydrocharged I think we support setting default character sets on tables, right? Can you do a pass and summarize what if anything is left to do here?

[timsehn]

I think this might be a way to access that information in GMS, not Dolt related?

[Hydrocharged]

I didn't quite understand the question. We support setting defaults on the table, and I pointed to it in my 2nd link. For clarification, I'm pointing to the collation, but the character set may be retrieved using collation.CharacterSet().

Since they didn't reply, I think we can assume that they may have figured that part out. I'm in favor of closing this for now, we can create another issue if my assumption is incorrect.

[zachmu]

My mistake, this is indeed a go-mysql-server specfic issue.

@fionera please let us know if there's more to do here. Closing in the meantime.