Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can a Table implement sql.IndexAddressableTable without implementing sql.DriverIndexableTable? #476

Closed
andremarianiello opened this issue Jun 21, 2021 · 3 comments

Comments

@andremarianiello
Copy link

I have an implementation of Table that also implements IndexAddressableTable but not DriverIndexableTable. When using this table in a the join node is correctly being replaced with an IndexedJoin node, and the table node is being replaced with an IndexedTableAccess as expected. However, the trackProcess rule is wrapping my table with a ProcessTable node which no longer implements IndexAddressableTable. This causes the IndexedTableAccess.RowIter to return ErrNoIndexableTable. Looking at the trackProcess rule, it seems like a similar concern was addressed because it takes special care of DriverIndexableTable nodes, but not IndexAddressableTable nodes. Should trackProcess be handling IndexAddressableTable nodes, or should I be implementing DriverIndexableTable (even though I don't think that is correct for my use-case).

@zachmu
Copy link
Member

zachmu commented Jun 30, 2021

I think this is a bug. Can you submit a patch?

@andremarianiello
Copy link
Author

Will do

@zachmu
Copy link
Member

zachmu commented Oct 6, 2022

Enough time has passed that I'm not certain that this bug still applies, and we definitely do not implement the Driver* interfaces in dolt, where indexed lookups work. Please reopen an issue if you can get a working repro demonstrating a defect here.

@zachmu zachmu closed this as completed Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants