You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have an implementation of Table that also implements IndexAddressableTable but not DriverIndexableTable. When using this table in a the join node is correctly being replaced with an IndexedJoin node, and the table node is being replaced with an IndexedTableAccess as expected. However, the trackProcess rule is wrapping my table with a ProcessTable node which no longer implements IndexAddressableTable. This causes the IndexedTableAccess.RowIter to return ErrNoIndexableTable. Looking at the trackProcess rule, it seems like a similar concern was addressed because it takes special care of DriverIndexableTable nodes, but not IndexAddressableTable nodes. Should trackProcess be handling IndexAddressableTable nodes, or should I be implementing DriverIndexableTable (even though I don't think that is correct for my use-case).
The text was updated successfully, but these errors were encountered:
Enough time has passed that I'm not certain that this bug still applies, and we definitely do not implement the Driver* interfaces in dolt, where indexed lookups work. Please reopen an issue if you can get a working repro demonstrating a defect here.
I have an implementation of Table that also implements IndexAddressableTable but not DriverIndexableTable. When using this table in a the join node is correctly being replaced with an IndexedJoin node, and the table node is being replaced with an IndexedTableAccess as expected. However, the trackProcess rule is wrapping my table with a ProcessTable node which no longer implements IndexAddressableTable. This causes the IndexedTableAccess.RowIter to return ErrNoIndexableTable. Looking at the trackProcess rule, it seems like a similar concern was addressed because it takes special care of DriverIndexableTable nodes, but not IndexAddressableTable nodes. Should trackProcess be handling IndexAddressableTable nodes, or should I be implementing DriverIndexableTable (even though I don't think that is correct for my use-case).
The text was updated successfully, but these errors were encountered: