From 979307b9aabbcdc3240be58c50b5ee39575cc9e9 Mon Sep 17 00:00:00 2001
From: Dominic Taylor <dominic@dominictaylor.dev>
Date: Mon, 19 Aug 2019 23:45:11 +0100
Subject: [PATCH] add rel=nopener to all links that contain target=blank 02
 https://developers.google.com/web/tools/lighthouse/audits/noopener

---
 html/cgi-bin/gpl.cgi                | 2 +-
 html/cgi-bin/logs.cgi/ids.dat       | 4 ++--
 html/cgi-bin/logs.cgi/urlfilter.dat | 2 +-
 html/cgi-bin/mpfire.cgi             | 2 +-
 html/cgi-bin/proxy.cgi              | 2 +-
 html/cgi-bin/tor.cgi                | 4 ++--
 html/cgi-bin/webaccess.cgi          | 4 ++--
 7 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/html/cgi-bin/gpl.cgi b/html/cgi-bin/gpl.cgi
index 94187ce7a3..2f6c2eca7f 100644
--- a/html/cgi-bin/gpl.cgi
+++ b/html/cgi-bin/gpl.cgi
@@ -74,7 +74,7 @@ print <<END;
 			<input type='submit' name='ACTION' value=$Lang::tr{'yes'} />
 		</form>
 	</p>
-	<a href='http://www.gnu.org/licenses/translations.html' target='_blank'>$Lang::tr{'gpl unofficial translation of the general public license v3'}</a>
+	<a href='http://www.gnu.org/licenses/translations.html' target='_blank' rel='noopener'>$Lang::tr{'gpl unofficial translation of the general public license v3'}</a>
 
 END
 
diff --git a/html/cgi-bin/logs.cgi/ids.dat b/html/cgi-bin/logs.cgi/ids.dat
index 8918bc6da6..6a6c7718c9 100644
--- a/html/cgi-bin/logs.cgi/ids.dat
+++ b/html/cgi-bin/logs.cgi/ids.dat
@@ -348,11 +348,11 @@ END
 	} elsif ($sid < 1000000) {
 		# Link to sourcefire if the the rule sid is less than 1000000.
 		print "<a href='https://www.snort.org/rule_docs/1-$sid' ";
-		print "target='_blank'>$sid</a></td>\n";
+		print "target='_blank' rel='noopener'>$sid</a></td>\n";
 	} elsif ($sid >= 2000000 and $sid < 3000000) {
 		# Link to emergingthreats if the rule sid is between 2000000 and 3000000.
 		print "<a href='http://doc.emergingthreats.net/$sid' ";
-		print "target='_blank'>$sid</a></td>\n";
+		print "target='_blank' rel='noopener'>$sid</a></td>\n";
 	} else {
 		# No external link for user defined rules
 		print $sid;
diff --git a/html/cgi-bin/logs.cgi/urlfilter.dat b/html/cgi-bin/logs.cgi/urlfilter.dat
index 221ed74ac6..52d7ba2861 100644
--- a/html/cgi-bin/logs.cgi/urlfilter.dat
+++ b/html/cgi-bin/logs.cgi/urlfilter.dat
@@ -365,7 +365,7 @@ if ($lines)
 				if (length($dsturl) > 69) { $site .= "..."; }
 			}
 			#print "<td>$site</td>\n";
-			print "<td $col><a href='$dsturl' title='$dsturl' target='_blank'>$site</a></td>\n";
+			print "<td $col><a href='$dsturl' title='$dsturl' target='_blank' rel='noopener'>$site</a></td>\n";
 		}
 		print "</tr>\n";
 	}
diff --git a/html/cgi-bin/mpfire.cgi b/html/cgi-bin/mpfire.cgi
index 6cec8ff338..14fadae72b 100644
--- a/html/cgi-bin/mpfire.cgi
+++ b/html/cgi-bin/mpfire.cgi
@@ -605,7 +605,7 @@ foreach (@webradio){
 	}
 	chomp $stream[1];chomp $stream[2];
 	print <<END
-<td align='left'><a href='$stream[2]' target='_blank'>$stream[1]</a></td>
+<td align='left'><a href='$stream[2]' target='_blank' rel='noopener'>$stream[1]</a></td>
 <td align='center'><form method='post' action='$ENV{'SCRIPT_NAME'}'><input type='hidden' name='FILE' value='$stream[0]' /><input type='hidden' name='ACTION' value='playweb' /><input type='image' alt='$Lang::tr{'play'}' title='$Lang::tr{'play'}' src='/images/media-playback-start.png' align='middle' />
 <input type='hidden' name='FRAME' value='$mpfiresettings{'FRAME'}' />
 </form></td>
diff --git a/html/cgi-bin/proxy.cgi b/html/cgi-bin/proxy.cgi
index 2e3efbbb70..f1a9b6d556 100644
--- a/html/cgi-bin/proxy.cgi
+++ b/html/cgi-bin/proxy.cgi
@@ -1021,7 +1021,7 @@ print <<END
 	<td colspan='4'><b>$Lang::tr{'advproxy cache management'}</b></td>
 </tr>
 <tr>
-	<td class='base'><a href='/cgi-bin/cachemgr.cgi' target='_blank'>$Lang::tr{'proxy cachemgr'}:</td>
+	<td class='base'><a href='/cgi-bin/cachemgr.cgi' target='_blank' rel='noopener'>$Lang::tr{'proxy cachemgr'}:</td>
 	<td><input type='checkbox' name='CACHEMGR' $checked{'CACHEMGR'}{'on'} /></td>
 	<td class='base'>$Lang::tr{'advproxy admin mail'}:</td>
 	<td><input type='text' name='ADMIN_MAIL_ADDRESS' value='$proxysettings{'ADMIN_MAIL_ADDRESS'}' /></td>
diff --git a/html/cgi-bin/tor.cgi b/html/cgi-bin/tor.cgi
index d31eb10862..7e50a40991 100644
--- a/html/cgi-bin/tor.cgi
+++ b/html/cgi-bin/tor.cgi
@@ -516,7 +516,7 @@ END
 					<tr>
 						<td width='40%' class='base'>$Lang::tr{'tor relay fingerprint'}:</td>
 						<td width='60%'>
-							<a href='https://metrics.torproject.org/rs.html#details/$fingerprint' target='_blank'>$fingerprint</a>
+							<a href='https://metrics.torproject.org/rs.html#details/$fingerprint' target='_blank' rel='noopener'>$fingerprint</a>
 						</td>
 					</tr>
 END
@@ -609,7 +609,7 @@ END
 				print <<END;
 					<tr>
 						<td width='40%'>
-							<a href='https://metrics.torproject.org/rs.html#details/$node->{'fingerprint'}' target='_blank'>
+							<a href='https://metrics.torproject.org/rs.html#details/$node->{'fingerprint'}' target='_blank' rel='noopener'>
 								$node->{'name'}
 							</a>
 						</td>
diff --git a/html/cgi-bin/webaccess.cgi b/html/cgi-bin/webaccess.cgi
index e687603f26..ff601eb9ef 100644
--- a/html/cgi-bin/webaccess.cgi
+++ b/html/cgi-bin/webaccess.cgi
@@ -232,8 +232,8 @@ print <<END
 <tr>
    <td bgcolor='#C0C0C0' align='right'>
       <font face='verdana,arial,helvetica' color='#FFFFFF' size='1'>
-      <a href='http://www.advproxy.net' target='_blank'>Advanced Proxy</a> running on
-      <a href='https://www.ipfire.org' target='_blank'>IPFire</a>
+      <a href='http://www.advproxy.net' target='_blank' rel='noopener'>Advanced Proxy</a> running on
+      <a href='https://www.ipfire.org' target='_blank' rel='noopener'>IPFire</a>
       </font>
    </td>
 </tr>