Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staticcheck: flag comparison of two reflect.Value #28

Open
dominikh opened this issue Feb 2, 2017 · 1 comment
Open

staticcheck: flag comparison of two reflect.Value #28

dominikh opened this issue Feb 2, 2017 · 1 comment
Labels
new-check

Comments

@dominikh
Copy link
Owner

dominikh commented Feb 2, 2017

Using == on two Values does not compare the underlying values they represent, but rather the contents of the Value structs. To compare two Values, compare the results of the Interface method.

Via golang/go#18871
@dominikh dominikh added the started Issues we've started working on label Feb 20, 2017
@dominikh dominikh added this to the 2017.3 milestone Nov 1, 2017
@dominikh dominikh removed this from the Next feature release milestone Jul 26, 2018
@dominikh dominikh removed the started Issues we've started working on label May 6, 2019
@dominikh
Copy link
Owner Author

Some interesting findings in golang/go#43993 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new-check
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dominikh