Add #[ReturnTypeWillChange] for PHP 8.1 support #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to go ahead and add 8.1 to mock-webserver/.github/workflows/ci.yml Line 14 in 356203d |
In PHP 8.1 the return type of JsonSerializable::jsonSerialize() was added. To maintain compatibility with older PHP versions the attribute #[ReturnTypeWillChange] was introduced. Deprecation warning: Return type of donatj\MockWebServer\RequestInfo::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice See also: https://wiki.php.net/rfc/internal_method_return_types As the package phpspec/prophecy (a dependency from phpunit) has not released yet a new version with PHP 8.1 compatibility I added a switch for composer install for the time being.
|
Awesome! I honestly wasn't sure how to resolve the prophecy issue but this works pretty elegantly. I would imagine when they tag a new release that works on 8.1, we can remove that! |
|
Do you have any need for me to tag a release? Otherwise I might wait until I get some other things I'm working on done, which could be a couple months if nothing comes up in the meantime. |
|
For me it is okay, can work with master. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP 8.1 the return type of JsonSerializable::jsonSerialize() was added.
To maintain compatibility with older PHP versions the attribute
#[ReturnTypeWillChange] was introduced.
Deprecation warning: Return type of donatj\MockWebServer\RequestInfo::jsonSerialize()
should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the
#[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
See also: https://wiki.php.net/rfc/internal_method_return_types