Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cssify should be a dependency in the plugin generator #158

Open
matthewp opened this issue Nov 29, 2016 · 7 comments
Open

cssify should be a dependency in the plugin generator #158

matthewp opened this issue Nov 29, 2016 · 7 comments

Comments

@matthewp
Copy link
Contributor

When browserify crawls through package.jsons it looks for "browser": "transforms" [ ] and applies those transformations. In order to find cssify, it needs to be a dependency of the project, not a devDependency.

We should either remove cssify from the generator or make it a project dependency.

@matthewp
Copy link
Contributor Author

Needs to be a dependency, removing it would be a breaking change and not interested in dealing with that right now.

@phillipskevin
Copy link
Contributor

should we remove it as a dependency for 1.0?

@matthewp
Copy link
Contributor Author

I don't know, maybe there should be a --css flag. I guess if you are writing a widget that includes css you'd want it for browserify users.

@pYr0x
Copy link

pYr0x commented Dec 21, 2016

Can we ask the user with a prompt if he would reuse the widget with browserify?

@matthewp
Copy link
Contributor Author

We could do some type of prompt, yeah. I wonder if it should be phrased as "Does this project use CSS" or something to that effect.

@justinbmeyer
Copy link

I'd keep it for 1.0. Easy enough to delete later.

@phillipskevin
Copy link
Contributor

There is a PR open to make it an opt-in if we want to use that: #136

cc @leoj3n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants