-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cssify should be a dependency in the plugin generator #158
Comments
Needs to be a dependency, removing it would be a breaking change and not interested in dealing with that right now. |
should we remove it as a dependency for 1.0? |
I don't know, maybe there should be a --css flag. I guess if you are writing a widget that includes css you'd want it for browserify users. |
Can we ask the user with a prompt if he would reuse the widget with browserify? |
We could do some type of prompt, yeah. I wonder if it should be phrased as "Does this project use CSS" or something to that effect. |
I'd keep it for 1.0. Easy enough to delete later. |
When browserify crawls through package.jsons it looks for
"browser": "transforms" [ ]
and applies those transformations. In order to find cssify, it needs to be adependency
of the project, not adevDependency
.We should either remove cssify from the generator or make it a project dependency.
The text was updated successfully, but these errors were encountered: