Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept other theme variables #214

Merged
merged 2 commits into from
Oct 14, 2022
Merged

feat: accept other theme variables #214

merged 2 commits into from
Oct 14, 2022

Conversation

hyochan
Copy link
Owner

@hyochan hyochan commented Oct 14, 2022

Description

feat: accept other theme variables in a custom theme.
test: import theme package locally in the storybook for live debugging.

Test Plan

Change logic in the theme package and test in the storybook and see if it applies dynamically.
Try to add a custom theme and check theme variables are merged correctly.

Related Issues

N/A

Tests

Ensure not failing.

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn test:all and make sure nothing fails. You can run yarn test -u to update snapshots if needed.
  • I am willing to follow-up on review comments in a timely manner.

@hyochan hyochan changed the title feat: accept theme variables feat: accept other theme variables Oct 14, 2022
@hyochan hyochan added 🍗 enhancement New feature or request 🎯 feature New feature labels Oct 14, 2022
@hyochan hyochan marked this pull request as ready for review October 14, 2022 03:16
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #214 (cf50777) into main (7c0c829) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   86.28%   86.54%   +0.26%     
==========================================
  Files          27       27              
  Lines         707      721      +14     
  Branches      292      304      +12     
==========================================
+ Hits          610      624      +14     
  Misses         97       97              

@hyochan hyochan merged commit 65b60bd into main Oct 14, 2022
@hyochan hyochan deleted the feat/accept-theme-vars branch October 14, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍗 enhancement New feature or request 🎯 feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant