feat: accept other theme variables #214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: accept other theme variables in a custom theme.
test: import theme package locally in the storybook for live debugging.
Test Plan
Change logic in the theme package and test in the storybook and see if it applies dynamically.
Try to add a custom theme and check theme variables are merged correctly.
Related Issues
N/A
Tests
Ensure not failing.
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.yarn test:all
and make sure nothing fails. You can runyarn test -u
to update snapshots if needed.