fix: storybook components tried to import wrong theme package #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #215 +/- ##
=======================================
Coverage 86.54% 86.54%
=======================================
Files 27 27
Lines 721 721
Branches 311 304 -7
=======================================
Hits 624 624
Misses 97 97 |
hyochan
reviewed
Oct 14, 2022
main/Button/stories/DefaultStory.tsx
Outdated
Comment on lines
9
to
10
| import {Button} from '..'; | ||
| import {Hr} from '../../Hr'; |
There was a problem hiding this comment.
I think the prev changes are better since we know that the components all lie on the same level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RadioButtonto work indocs.accordionwas not rendered indocs.Test Plan
N/A
Related Issues
N/A
Tests
I added the following tests:
N/A
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.yarn test:alland make sure nothing fails. You can runyarn test -uto update snapshots if needed.