Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for double callback consume crash #397

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

pavel-alexeichik
Copy link
Contributor

This commit fixes #315
Previous pull request #379 fixed the issue just partially.
Here is the stack showing the case when the app crashes:

java.lang.RuntimeException: 
  at com.facebook.react.bridge.CallbackImpl.invoke (CallbackImpl.java:28)
  at com.facebook.react.bridge.PromiseImpl.reject (PromiseImpl.java:68)
  at com.facebook.react.bridge.PromiseImpl.reject (PromiseImpl.java:36)
  at com.dooboolab.RNIap.RNIapModule.rejectPromiseWithBillingError (RNIapModule.java:458)
  at com.dooboolab.RNIap.RNIapModule.access$300 (RNIapModule.java:46)
  at com.dooboolab.RNIap.RNIapModule$3.onBillingSetupFinished (RNIapModule.java:132)
  at com.android.billingclient.api.BillingClientImpl$BillingServiceConnection.onServiceConnected (BillingClientImpl.java:908)
 
  at android.app.LoadedApk$ServiceDispatcher.doConnected (LoadedApk.java:1839)
  at android.app.LoadedApk$ServiceDispatcher$RunConnection.run (LoadedApk.java:1871)
  at android.os.Handler.handleCallback (Handler.java:873)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loop (Looper.java:214)
  at android.app.ActivityThread.main (ActivityThread.java:6981)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:493)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1445)

@hyochan hyochan self-requested a review February 11, 2019 13:58
@hyochan hyochan added 🤖 android Related to android 🛠 bugfix All kinds of bug fixes labels Feb 11, 2019
@hyochan hyochan merged commit 1286b3c into hyochan:master Feb 12, 2019
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve this PR. Thank you for contribution.

@pavel-alexeichik
Copy link
Contributor Author

@hyochan Thank you for this great module 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Related to android 🛠 bugfix All kinds of bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android crashes in many devices after release
2 participants