Hey @foster-hangdaan, I hate to nitpick but I believe the NVim port has italic comments and keywords across all variants. I can't submit a PR to the PR so could you please slant them? I really like them.

Hey @foster-hangdaan, I hate to nitpick but I believe the NVim port has italic comments and keywords across all variants. I can't submit a PR to the PR so could you please slant them? I really like them.

The keywords and comments for the variants have been italicized. Note that I will not be modifying the original Night theme since it will be out of scope for this PR which already brings three new variants.

But it looks very different than the upstream.

But it looks very different than the upstream.

Worth noting: "upstream" is considered to be the VSCode theme, not the NVim port. Also, are you certain you're using the same variant in each app? Looks like Neovide is in Storm, whereas DOOM is in Night or Moon.

But it looks very different than the upstream.

Thanks for the feedback. More screenshots of the Moon variant will be handy since I based the variant from the single screenshot that was provided on the Neovim port. I also didn't feel like crawling through the Lua code to obtain all the syntax highlighting rules.

Some things that probably won't be fixed based on those screenshots:

• Language-specific syntax highlighting. Take the Doom port, for example, Elisp's use-package and Rust's let are keywords and are simply following the global rule which specifies that keywords should be magenta. On the other hand we have the Neovim port, where Elisp's use-package is magenta (OK) but then uses a language-specific rule for Rust's let keyword which makes it cyan.

  I believe applying language-specific rules will be a community effort to pull off since it will require testing and modifying font faces for each major mode. It would be helpful if users could submit font face rules for their preferred major modes and I will gladly apply them to this PR.

Some things that will be fixed:

• Strings are a slightly lighter tint of green.
• Types should be in blue and not grey. i.e. IpAddr.

but then uses a language-specific rule for Rust's let keyword which makes it cyan.

Yes, you are correct, those colors will be changed If I disable the lsp.

Types should be in blue and not grey. i.e. IpAddr.

What about base_url and http.port? is it anguage-specific syntax highlighting.?

but then uses a language-specific rule for Rust's let keyword which makes it cyan.

Yes, you are correct, those colors will be changed If I disable the lsp.

Types should be in blue and not grey. i.e. IpAddr.

What about base_url and http.port? is it anguage-specific syntax highlighting.?

I cannot check the Rust major mode since I don't have it nor its LSP installed, but it's probably the same reason why the syntax highlighting are not being applied for TypeScript methods and properties. On the screenshot below, crypto.subtle and data.buffer properties should be in dark-cyan:

When I inspect their text properties, they have no associated font-face:

Without a font face, there is nothing to target for highlighting, and it seems to fallback to the theme's foreground color.

So now you're probably asking why they don't have an associated font face? Not sure; that is beyond the limits of my Emacs-fu 😢. My blame goes to the major mode and it is somehow not able to identify the syntax. I've looked around and this problem exists in several major modes.

TL;DR: It's an underlying Emacs issue (I think) and is out of the scope of a theme to fix.

Also @azzamsa and other Moon variant users, I would like to ask if it's really worth trying to copy the syntax highlighting rules of the Neovim port? Not only will it take a lot of work, but I also think that the Doom highlighting rules are superior since they are more consistent across all major modes, whereas the Neovim port's rules are more arbitrary. Though, I do admit that the Neovim port is more colorful.

TL;DR: It's an underlying Emacs issue (I think) and is out of the scope of a theme to fix.

Ah, Okay I see.

Though, I do admit that the Neovim port is more colorful.

It would be nice to look similar to neovim without enabling the lsp (language-specific rule).
We can safely ignore the color from language-specific rules.

A random suggestion for storm theme: Have type as teal instead of base8.

A random suggestion for storm theme: Have type as teal instead of base8.

This is to differentiate type from variable as both are set to base8 as of now.

A random suggestion for storm theme: Have type as teal instead of base8.

This is to differentiate type from variable as both are set to base8 as of now.

Sounds good to me. I will also do the same for the light theme and change type to something more colorful than the current dull, grayish color.