Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: update for #9086? #9154

Closed
MrTact opened this issue Mar 11, 2023 · 2 comments
Closed

Documentation: update for #9086? #9154

MrTact opened this issue Mar 11, 2023 · 2 comments

Comments

@MrTact
Copy link

MrTact commented Mar 11, 2023

Which packages are impacted by your issue?

No response

Describe the bug

#9086 looks like it changes the way TypeScript config files are loaded. The website references TypeScript-based config files, calling out the use of cosmiconfig explicitly toward the end: https://github.com/dotansimha/graphql-code-generator/blob/master/website/src/pages/docs/config-reference/codegen-config.mdx

  • Does this change invalidate any of that documentation?
  • Is there anything new that needs to be called out (e.g. the use of jiti)?

I would normally just submit a PR for something like this, but the project is pretty new to me and that PR is a bit beyond my understanding, so I figured filing an issue was probably a good approach.

Your Example Website or App

N/A

Steps to Reproduce the Bug or Issue

N/A

Expected behavior

N/A

Screenshots or Videos

N/A

Platform

The graphq-codegen website (https://the-guild.dev/graphql/codegen/docs/config-reference/codegen-config)

Codegen Config File

N/A

Additional context

No response

@beerose
Copy link
Contributor

beerose commented Mar 28, 2023

Hey! The Codegen still uses cosmiconfig to manage configuration files, but we dropped cosmiconfig-typescript-loader in favor of jiti (to be able to support ESM). This means everything works as before, but now you can have a typescript config file along with type: module in package.json, and you can use .mts and .cts extensions. I'm gonna add this information to the docs.

@beerose
Copy link
Contributor

beerose commented Mar 28, 2023

Fixed in #9238

@beerose beerose closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants