Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Median instead of Mean whe deducing Overhead #1116

Closed
adamsitnik opened this issue Mar 27, 2019 · 2 comments
Closed

Use Median instead of Mean whe deducing Overhead #1116

adamsitnik opened this issue Mar 27, 2019 · 2 comments
Assignees
Milestone

Comments

@adamsitnik
Copy link
Member

I just had a conversation with @AndyAyersMS and Andy asked if we remove the outliers from the overhead.

I did check our code and it looks like we don't:

double overhead = Overhead == null ? 0.0 : new Statistics(Overhead.Select(m => m.Nanoseconds)).Mean;

Andy has run into a case where it would make a lot of sense:

1.69
1.65
1.70
1.83
2.60 <-- an outlier -->
1.76
1.69
1.69
1.73
1.64
1.66
1.67
1.71
1.68
1.64

@AndreyAkinshin I think that we should remove the outliers from the Overhead. Do you agree?

@AndreyAkinshin
Copy link
Member

@adamsitnik thanks for report, it's a good point. However, I decided that it will be better to just use Median instead of Mean.

@adamsitnik
Copy link
Member Author

Median instead of Mean

the simplest solutions are always the best! thanks!

@adamsitnik adamsitnik added this to the v0.11.5 milestone Mar 28, 2019
@adamsitnik adamsitnik changed the title Should we exclude outliers from the overhead? Use Median instead of Mean whe deducing Overhead Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants