Add an option to pass environment variables to the default job

[filipnavara]

When testing against the mono/netcore runtime we often want to run the actual benchmark with specific runtime configuration. This is achieved through setting the MONO_ENV_OPTIONS environment variable. However, we also want to use different MONO_ENV_OPTIONS when running dotnet restore or dotnet build for performance reasons. It would be nice to allow some way to inject the environment variables but only for the actul benchmark job.

What I currently use is the following hack:
filipnavara/performance@d1768c7

/cc @EgorBo

[adamsitnik]

Do I understand correctly that you would like to have the possibility to specify two different set of env vars, one for dotnet build|restore executed by BDN and another for the benchmark process?

[filipnavara]

Do I understand correctly that you would like to have the possibility to specify two different set of env vars, one for dotnet build|restore executed by BDN and another for the benchmark process?

That's correct. However, the ones for dotnet build|restore can be set in the context of the outer process so there's no need for a mechanism to set them inside BDN.

[adamsitnik]

Ok, so the thing that you are currently doing looks good to me (you are using the right API for the job).

Does it mean that you would like to somehow pass the env vars via console line arguments?

[EgorBo]

Does it mean that you would like to somehow pass the env vars via console line arguments?

Would be nice! 🙂

[adamsitnik]

@EgorBo ok, so I've transferred the issue to BDN repo

@filipnavara could you please write some proposal? Would sth like this be enough?

--envVars firstKey:firstValue secondKey:secondValue

[filipnavara]

Would sth like this be enough?

--envVars firstKey:firstValue secondKey:secondValue

Yep, it would be.

[adamsitnik]

#1313