Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AssetManifestFileName should have better default or be configurable #3532

Closed
AaronRobinsonMSFT opened this issue Aug 1, 2019 · 0 comments · Fixed by #3534
Closed

AssetManifestFileName should have better default or be configurable #3532

AaronRobinsonMSFT opened this issue Aug 1, 2019 · 0 comments · Fixed by #3534

Comments

@AaronRobinsonMSFT
Copy link
Member

The below code relies on an assumption that doesn't work well. The MSBuild constant property OS will only ever be Windows_NT or Unix - dotnet/msbuild#539. This makes the below code generated possibly invalid manifests on macOS build legs.

arcade/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj

Lines 33 to 34 in 6ec2a58

<AssetManifestFileName>$(OS)-$(PlatformName).xml</AssetManifestFileName>
<AssetManifestFilePath>$(ArtifactsLogDir)AssetManifest\$(AssetManifestFileName)</AssetManifestFilePath>

cc @sbomer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configuration point for asset manifest name AaronRobinsonMSFT/arcade
1 participant
@AaronRobinsonMSFT