Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the artifact category mechanism in PublishArtifactsInManifest task #3828

Closed
riarenas opened this issue Sep 3, 2019 · 2 comments
Closed

Comments

@riarenas
Copy link
Member

riarenas commented Sep 3, 2019

The current approach of keeping a static mapping of extension -> category

var whichCategory = new Dictionary<string, string>()
{
{ ".NUPKG", "NETCORE" },
{ ".PKG", "OSX" },
{ ".DEB", "DEB" },
{ ".RPM", "RPM" },
{ ".NPM", "NODE" },
{ ".ZIP", "BINARYLAYOUT" },
{ ".MSI", "INSTALLER" },
{ ".SHA", "CHECKSUM" },
{ ".POM", "MAVEN" },
{ ".VSIX", "VSIX" },
};

means that whenever we need to add or change these categories, we need to:

  • Generate a new version of the task package
  • Change the version files of the Arcade SDK to use the new task package

The process is not great whenever a new extension needs to be added.

A possible solution is to simplify the categories into:

  • Packages (NuGet packages)
  • Blobs (Everything else)
  • Hybrid (Blobs that are also packages, such as symbol packages)
@mmitche
Copy link
Member

mmitche commented Oct 25, 2019

Not needed for 3.1, moving to 5

@riarenas
Copy link
Member Author

Fits the theme of improvements that we want to make for .NET 5. Keeping in the current epic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants