Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure XHarness telemetry is sent even when job times out #7899

Closed
premun opened this issue Sep 15, 2021 · 0 comments · Fixed by #7936
Closed

Make sure XHarness telemetry is sent even when job times out #7899

premun opened this issue Sep 15, 2021 · 0 comments · Fixed by #7936
Assignees
@premun

Comments

@premun
Copy link
Member

premun commented Sep 15, 2021

Context

When we call user commands inside of the Helix SDK, we have to make sure that when they time out, we still send the telemetry at the end of the job (we do it via HelixPostCommands).

To be done

  • Investigate behavior of HelixPostCommands and whether they get called even when command times out
  • Make sure telemetry is sent, i.e. time-constrain user commands and leave buffer to send the telemetry at the end
@premun premun self-assigned this Sep 15, 2021
@ghost ghost added the Needs Triage A new issue that needs to be associated with an epic. label Sep 15, 2021
@premun premun removed the Needs Triage A new issue that needs to be associated with an epic. label Sep 15, 2021
@premun premun mentioned this issue Sep 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@premun premun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Time-constrain user commands in XHarness workloads premun/arcade
1 participant
@premun