Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure wix tooling is up to date in staging pipeline #7946

Closed
1 of 2 tasks
mmitche opened this issue Sep 23, 2021 · 6 comments
Closed
1 of 2 tasks

Ensure wix tooling is up to date in staging pipeline #7946

mmitche opened this issue Sep 23, 2021 · 6 comments
Assignees
Labels
Needs Triage A new issue that needs to be associated with an epic.

Comments

@mmitche
Copy link
Member

mmitche commented Sep 23, 2021

  • This issue is blocking
  • This issue is causing unreasonable pain

After changes to the wix tooling to support some key scenarios, we are using a new version in RC2+. Because we relink after signing in the staging pipeline, we need to update the version of the tooling we use there too, if it hasn't already been done transparently (I can't remember how the version is specified)

Here is the tooling package to use: https://netcorenativeassets.blob.core.windows.net/resource-packages/external/windows/wix/Microsoft.Signed.Wix-1.0.0-v3.14.0.4118.zip

@ghost ghost added the Needs Triage A new issue that needs to be associated with an epic. label Sep 23, 2021
@mmitche
Copy link
Member Author

mmitche commented Sep 23, 2021

/cc @joeloff @adiaaida

@mmitche mmitche self-assigned this Sep 23, 2021
@MattGal
Copy link
Member

MattGal commented Sep 23, 2021

[Async Triage]: Small change which is necessary in Arcade which Matt has already self assigned, tossing in FR for tracking.

@michellemcdaniel
Copy link
Contributor

@missymessa who may know how we specify/get the wix version

@michellemcdaniel
Copy link
Contributor

FYI, the release repo is currently blocked on getting the latest arcade version (assuming that is how we get the WiX tools). I will look into it, but I'm hesitant to allow the update to 7.0 arcade for 6.0 releases, since there may be changes that break the pipeline.

@michellemcdaniel
Copy link
Contributor

This target is how we get the WiX tools: https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Build.Tasks.Installers/build/wix/wix.targets

@MattGal
Copy link
Member

MattGal commented Sep 27, 2021

This was merged via #7947 (main) and #7948 (release/6.0), so closing this issue unless we also need this somewhere else (the wix.targets patched wasn't present <= release/5.0)

@MattGal MattGal closed this as completed Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Triage A new issue that needs to be associated with an epic.
Projects
None yet
Development

No branches or pull requests

3 participants