Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arcade property paths are incompletely changed #8642

Closed
crummel opened this issue Mar 11, 2022 · 3 comments · Fixed by #9127
Closed

Arcade property paths are incompletely changed #8642

crummel opened this issue Mar 11, 2022 · 3 comments · Fixed by #9127

Comments

@crummel
Copy link
Contributor

crummel commented Mar 11, 2022

In Arcade, we have conditional TFMs to build for net6.0 instead of net3.1 when building with DotNetBuildFromSource=true. However, these changes have failed to account for some places where the TFM is embedded into paths that need to be accessed during the build run - for instance,

<ArcadeSdkBuildTasksAssembly Condition="'$(MSBuildRuntimeType)' != 'Core'">$(MSBuildThisFileDirectory)net472\Microsoft.DotNet.Arcade.Sdk.dll</ArcadeSdkBuildTasksAssembly>
<ArcadeSdkBuildTasksAssembly Condition="'$(MSBuildRuntimeType)' == 'Core'">$(MSBuildThisFileDirectory)netcoreapp3.1\Microsoft.DotNet.Arcade.Sdk.dll</ArcadeSdkBuildTasksAssembly>
. There was a change made in main to account for one instance of this: 9ffc76a but this hasn't been backported yet and should be expanded to most places the TFM is embedded in a path.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@markwilkie
Copy link
Member

Do you have any thoughts on who should do this work @crummel ?

@crummel
Copy link
Contributor Author

crummel commented Mar 24, 2022

I just sent out a meeting to discuss the related issue #7413 which I think we'll want to figure out first, I'll add you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants