Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource health check polling (cloud traffic concerns) #5602

Closed
mitchdenny opened this issue Sep 9, 2024 · 3 comments · Fixed by #5870
Closed

Resource health check polling (cloud traffic concerns) #5602

mitchdenny opened this issue Sep 9, 2024 · 3 comments · Fixed by #5870
Assignees
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication perf Issues pertaining to Perf
Milestone

Comments

@mitchdenny
Copy link
Member

In #5601 we reduce the period for health check execution. We go from 30 seconds to 5 seconds. Some cloud hosted resources could be more expensive for health check intervals.

Do we need to introduce a Period property on the HealthCheckAnnotation and then improve the logic in ResourceHealthCheckScheduler to enable or disable a check based on whether the per resource internal has been reached. We might want to have two intervals, one for startup and one for normal running with the AddXYZResource method able to set the sensible default.

This would make the scheduler more complex.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Sep 9, 2024
@mitchdenny
Copy link
Member Author

/cc @davidfowl

@mitchdenny
Copy link
Member Author

Moving this to Backlog. PR #5870 should address most of the issues. We can look at this complete back-off if necessary down the track.

@mitchdenny mitchdenny modified the milestones: 9.0, Backlog Sep 25, 2024
@davidfowl davidfowl closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2024
@Alirexaa
Copy link
Contributor

@davidfowl, this issue in 9.0.0-rc.1 caused Meilisearch container logs to get noisy.

Image

Can we solve this issue in 9.*?

We should reopen this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication perf Issues pertaining to Perf
Projects
None yet
3 participants