[WebToolsE2E][Aspire] Running aspire project using CLI, the "Finished" status is marked red when clicking the Stop button of a project under Actions.

[vmykagapuz]

INSTALL STEPS

1. Clean machine: Win11 x64 23h2 ENU
2. Install SDK 9.0 GA
3. Install Aspire 9.0 GA
4. Install VS or VSCode

REPRO STEPS

1. Open Command Prompt, run the following code to create an aspire starter app
   dotnet new aspire-starter -o aspire1
2. Run the following command:
   cd aspire1/aspire1.AppHost
dotnet run
3. Open any url to go dashboard
4. Click the 'Stop' button any project under Actions

ACTUAL
Run the project using CLI, the "Finished" status under State is marked in red.

EXPECTED
Run the project using VS and VS Code, the "Finished" status under State is marked in gray.

[vmykagapuz]

This issue is the same with the issue #6203 but that one is marked as already fixed.

[joperezr]

Sounds like this might be an inconsistency of how dcp handles the projects that are launching? Or perhaps something different in app model? cc: @karolz-ms @mitchdenny

[karolz-ms]

@balachir @joperezr I assume this is not a ship-stopper for 9.0?

[joperezr]

I don't think so either, but it would be good to understand what the issue is and see if this is something we can fix in our first servicing

[karolz-ms]

Agreed

[davidfowl]

The icon change is by design, a change by @drewnoakes

[joperezr]

Ok, let's review today in our workitem meeting and then either close if by design or update milestone + Priority if not as this is not blocking for 9.0.

[drewnoakes]

I changed it to be grey in #6231:

I'm not sure how it ended up red. Perhaps @adamint knows, as he made some changes to statuses when working on health checks.

[drewnoakes]

The code hasn't changed since my PR:

aspire/src/Aspire.Dashboard/Model/ResourceStateViewModel.cs

Lines 31 to 42 in be2a895

	if (resource.TryGetExitCode(out var exitCode) && exitCode is not 0)
	{
	// Process completed unexpectedly, hence the non-zero code. This is almost certainly an error, so warn users.
	icon = new Icons.Filled.Size16.ErrorCircle();
	color = Color.Error;
	}
	else if (resource.IsFinishedState())
	{
	// Process completed successfully.
	icon = new Icons.Regular.Size16.RecordStop();
	color = Color.Info;
	}

The icon in the screenshot looks like ErrorCircle, which would suggest a non-zero exit code.

@vmykagapuz what tool tip do you see on the state cell? It will tell you if the exit was unexpected and the exit code if it was non-zero.

[danmoseley]

Should there be a way (hover?) to see the actual exit code?

[davidfowl]

Details view?

[drewnoakes]

The state cell's tool tip does show the exit code too, if non-zero.

aspire/src/Aspire.Dashboard/Model/ResourceStateViewModel.cs

Lines 98 to 112 in be2a895

	internal static string GetResourceStateTooltip(ResourceViewModel resource, IStringLocalizer<Columns> loc)
	{
	if (resource.IsStopped())
	{
	if (resource.TryGetExitCode(out var exitCode) && exitCode is not 0)
	{
	// Process completed unexpectedly, hence the non-zero code. This is almost certainly an error, so warn users.
	return loc.GetString(nameof(Columns.StateColumnResourceExitedUnexpectedly), resource.ResourceType, exitCode);
	}
	else
	{
	// Process completed, which may not have been unexpected.
	return loc.GetString(nameof(Columns.StateColumnResourceExited), resource.ResourceType);
	}
	}

[vmykagapuz]

@drewnoakes Regarding to the tool tip you mentioned, it shows "Project exited unexpectedly with exit code 1"

[davidfowl]

Moving to the backlog. This isn’t a blocker. We should understand why dcp doesnt gracefully shutdown processes though.

cc @karolz-ms