Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CosmosDB Components should allow for CosmosClientOptions to be configured via IConfiguration #667

Open
eerhardt opened this issue Nov 2, 2023 · 5 comments
Open

CosmosDB Components should allow for CosmosClientOptions to be configured via IConfiguration #667

eerhardt opened this issue Nov 2, 2023 · 5 comments
Assignees
@kundadebdatta
Labels
area-integrations Issues pertaining to Aspire Integrations packages azure Issues associated specifically with scenarios tied to using Azure azure-cosmosdb Issues related to Azure CosmosDB
Milestone
Backlog

Comments

@eerhardt
Copy link
Member

eerhardt commented Nov 2, 2023

With #359, we added CosmosDB Components. ComosDB follows the same pattern as other Azure clients - it has XXXClient and XXXClientOptions objects.

The other Azure components allow for the XXXClientOptions object to be bound to IConfiguration, so users can tweak their settings without rebuilding/redeploying the app.

We should enable the same behavior in the CosmosDB components.
@eerhardt eerhardt added the area-integrations Issues pertaining to Aspire Integrations packages label Nov 2, 2023
@eerhardt eerhardt added this to the some time after preview milestone Nov 2, 2023
@eerhardt eerhardt mentioned this issue Nov 2, 2023
Merged
@danmoseley danmoseley removed this from the needs milestone (for GA) milestone Nov 13, 2023
@davidfowl davidfowl added this to the preview TBD (but in 8.0) milestone Jan 27, 2024
@davidfowl
Copy link
Member

Do we still want to do this?

@eerhardt
Copy link
Member Author

Do we still want to do this?

I think so. It should be consistent with the other Azure components.

@eerhardt
Copy link
Member Author

@Pilchie - is this something your team plans on implementing?

@eerhardt eerhardt modified the milestones: preview TBD (but in 8.0), GA Feb 26, 2024
@eerhardt eerhardt modified the milestones: GA, preview 6 (Apr) Mar 4, 2024
@eerhardt eerhardt modified the milestones: preview 6 (Apr), 8.1 Apr 1, 2024
@eerhardt eerhardt mentioned this issue Apr 17, 2024
Closed
@eerhardt
Copy link
Member Author

@kundadebdatta - can I assign this issue to you?

@kundadebdatta kundadebdatta mentioned this issue Apr 18, 2024
Open
@eerhardt
Copy link
Member Author

@kundadebdatta - can you comment on this issue so I can assign it to you?

@eerhardt eerhardt modified the milestones: 8.1, Backlog Jul 15, 2024
@davidfowl davidfowl added azure Issues associated specifically with scenarios tied to using Azure azure-cosmosdb Issues related to Azure CosmosDB labels Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kundadebdatta kundadebdatta

Labels
area-integrations Issues pertaining to Aspire Integrations packages azure Issues associated specifically with scenarios tied to using Azure azure-cosmosdb Issues related to Azure CosmosDB
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@davidfowl @danmoseley @eerhardt @kundadebdatta