Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin a couple of packages in 3.0 and 3.1 branches #18519

Closed
4 tasks done
dougbu opened this issue Jan 22, 2020 · 13 comments
Closed
4 tasks done

Pin a couple of packages in 3.0 and 3.1 branches #18519

dougbu opened this issue Jan 22, 2020 · 13 comments
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed
Milestone

Comments

@dougbu
Copy link
Member

dougbu commented Jan 22, 2020

After the (long) discussion in #18364 about CoreFx package versions where we only need ref/ assemblies, should also pin the following to their .0 versions in 'release/3.0' and 'release/3.1' branches:

  • Microsoft.Win32.Registry
  • System.Security.Principal.Windows

(We do not seem to need ref/ assemblies from other packages shown in https://github.com/dotnet/runtime/search?q=isnetcoreappref&unscoped_q=isnetcoreappref @ericstj please confirm those properties are the same for 3.0, 3.1 and 5.0 -- GitHub search doesn't help much.)

Extensions

AspNetCore

EFCore, Aspnetcore-Tooling, Blazor, and EF6 don't depend on any of these packages, so nothing is needed there

@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 22, 2020
@dougbu
Copy link
Member Author

dougbu commented Jan 22, 2020

Hmm, can't add this to https://github.com/orgs/aspnet/projects/2 My preference is to:

  • Move that project to the dotnet organization
  • Move the aspnet/AspNetCore-Internal repo to the dotnet organization
  • Update RasS to understand the changed landscape

@Pilchie and @anurse do you know a way to move a project between organizations? If we're agreed, could you do that and the AspNetCore-Internal repo move?

@dougbu
Copy link
Member Author

dougbu commented Jan 22, 2020

/fyi @ericstj @nguerrera @mmitche

@ericstj
Copy link
Member

ericstj commented Jan 22, 2020

confirm those properties are the same for 3.0, 3.1 and 5.0

Yes we've represented this the same way since 2.0.

@wtgodbe wtgodbe added this to the 3.1.3 milestone Jan 22, 2020
@analogrelay
Copy link
Contributor

@dougbu I don't see a way to move projects between orgs. That's probably because projects can generally only contain issues from repos in the same org, so it gets a little complicated. We could open a new project and work on migrating issues.

As for moving AspNetCore-Internal, I'm fine with that but don't have the necessary permissions in the dotnet org to do so.

@Pilchie
Copy link
Member

Pilchie commented Jan 22, 2020

As for moving AspNetCore-Internal, I'm fine with that but don't have the necessary permissions in the dotnet org to do so.

I don't either, but @jaredpar could probably do it for us.

@jaredpar
Copy link
Member

Yes I can do it. Can someone positively state they want me to move AspNetCore-Internal to the dotnet org? The language so far is "i'm fine with it". Want to verify before I do the move.

@Pilchie
Copy link
Member

Pilchie commented Jan 23, 2020

Please go ahead and move AspNetCore-Internal to the dotnet org whenever it's convenient to you, and let me know when you are done.

@jaredpar
Copy link
Member

Assuming it should be named aspnetcore-internal (casing change) to match the other moves?

@Pilchie
Copy link
Member

Pilchie commented Jan 23, 2020

Yes, sounds good to me.

@jaredpar
Copy link
Member

The transfer has happened. There is one new team though we hadn't ported yet: aspdoi. Do you need that ported? Seems that aspnet-push had enough overlap that this shouldn't be a problem.

@Pilchie
Copy link
Member

Pilchie commented Jan 23, 2020

Thanks!

For aspdoi I had created it, but apparently not populated it :) https://github.com/orgs/dotnet/teams/aspdoi

It's there for mentioning, not for permissions, so we can do that on our own.

@jawn
Copy link

jawn commented Apr 1, 2020

As 3.1.3 has been released, should this be moved to a later milestone?

@wtgodbe wtgodbe added the Done This issue has been fixed label Apr 1, 2020
@wtgodbe
Copy link
Member

wtgodbe commented Apr 1, 2020

The issue was resolved in 3.1.3, so should be fine to keep that as its milestone - I guess I just forgot to close it 🤦‍♂

@wtgodbe wtgodbe closed this as completed Apr 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed
Projects
None yet
Development

No branches or pull requests

8 participants