Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Core SDK 3.1.111 ASP.NET Core targeting pack files are newer in .exe installer than .zip package #28331

Closed
dagood opened this issue Nov 25, 2020 · 10 comments
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-installers Includes: Installers

Comments

@dagood
Copy link
Member

dagood commented Nov 25, 2020

[@NicoleWang001 dotnet/runtime#3756 (comment)]
With SDK 3.1.107 and 3.1.401, ref files (files on .\packs\Microsoft.AspNetCore.App.Ref\3.1.3\ref\netcoreapp3.1) on .exe installer is more recent than .zip installer.
image

[@vdanche dotnet/runtime#3756 (comment)]
[...] Still repro on SDK 3.1.111, ref files (files on .\packs\microsoft.aspnetcore.app.ref\3.1.10\ref\netcoreapp3.1) on .exe installer is more recent than .zip installer.
image


Transfered from from dotnet/runtime#3756.

@vdanche
Copy link
Member

vdanche commented Nov 30, 2020

Also repro on net 5 RTM x86 SDK(5.0.100-rtm.20526.5), will track this bug also.
image

@marcpopMSFT marcpopMSFT transferred this issue from dotnet/installer Dec 2, 2020
@marcpopMSFT
Copy link
Member

It appears the contents of the msi and nupkg for the targeting pack are different which they shouldn't be.

@javiercn javiercn added the feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform label Dec 3, 2020
@javiercn
Copy link
Member

javiercn commented Dec 3, 2020

@dagood thanks for the report.

@dotnet/aspnet-build do you have any thoughts?

@wtgodbe
Copy link
Member

wtgodbe commented Dec 3, 2020

Huh, interesting - I'll take a look

@wtgodbe
Copy link
Member

wtgodbe commented Dec 3, 2020

The reason, at least for us, is that the .nupkg input files are from the various project output directories, while the .zip input files are from a centralized location where we copy all of those project output files to create a layout. So, it's the same set of files, but the ones in the .zip have been copied one extra time.

@wtgodbe
Copy link
Member

wtgodbe commented Dec 4, 2020

@dagood does this still sound like an issue, given the above?

@dagood
Copy link
Member Author

dagood commented Dec 7, 2020

I'm not sure what the issue is, I just moved it here from a thread in dotnet/runtime. 😄
@NicoleWang001 and @vdanche may be able to provide more context.

@vdanche
Copy link
Member

vdanche commented Dec 8, 2020

@dagood The issue is that .NET SDK installers have different contents as the zip archives, e.g. With SDK 3.1.405, ref files (files on .\packs\Microsoft.AspNetCore.App.Ref\3.1.10\ref\netcoreapp3.1) on .zip installer is more recent than .exe installer.

Repro steps:

  1. Installing the .NET Core SDK 3.1.405(Use release/3.1.4XX branch from https://github.com/dotnet/core-sdk)
  2. Downloading and extracting the zip archive of the .NET Core SDK
  3. Running a folder diff on the extracted SDK and the install folder
    Tool WinDiff : \bvtsrv2\Team\v-yunwei\Docshare\windiff

Expected Result:
The installers include identical contents as the zip archives

Actual Result:
.NET SDK installers have different contents as the zip archives, ref files (files on .\packs\Microsoft.AspNetCore.App.Ref\3.1.10\ref\netcoreapp3.1) on .zip installer is more recent than .exe installer.
image
image

@wtgodbe
Copy link
Member

wtgodbe commented Dec 23, 2020

This is not an issue - the files are the same, the reason that the last-modified stamp is different is because the files in the .zip were copied from their original location to a layout folder. @NicoleWang001 was this caught by a CTI validation scenario? If so, can we modify that validation scenario so that we check for FileVersion rather than for the last modified date?

@wtgodbe wtgodbe closed this as completed Dec 23, 2020
@vdanche
Copy link
Member

vdanche commented Dec 25, 2020

@wtgodbe Got it! We'll make note in our test scenario. Thanks much!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 24, 2021
@JunTaoLuo JunTaoLuo added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-installers Includes: Installers and removed feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform labels Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework feature-installers Includes: Installers
Projects
None yet
Development

No branches or pull requests

6 participants