-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET Core SDK 3.1.111 ASP.NET Core targeting pack files are newer in .exe installer than .zip package #28331
Comments
It appears the contents of the msi and nupkg for the targeting pack are different which they shouldn't be. |
@dagood thanks for the report. @dotnet/aspnet-build do you have any thoughts? |
Huh, interesting - I'll take a look |
The reason, at least for us, is that the .nupkg input files are from the various project output directories, while the .zip input files are from a centralized location where we copy all of those project output files to create a layout. So, it's the same set of files, but the ones in the .zip have been copied one extra time. |
@dagood does this still sound like an issue, given the above? |
I'm not sure what the issue is, I just moved it here from a thread in dotnet/runtime. 😄 |
@dagood The issue is that .NET SDK installers have different contents as the zip archives, e.g. With SDK 3.1.405, ref files (files on .\packs\Microsoft.AspNetCore.App.Ref\3.1.10\ref\netcoreapp3.1) on .zip installer is more recent than .exe installer. Repro steps:
Expected Result: Actual Result: |
This is not an issue - the files are the same, the reason that the last-modified stamp is different is because the files in the .zip were copied from their original location to a layout folder. @NicoleWang001 was this caught by a CTI validation scenario? If so, can we modify that validation scenario so that we check for FileVersion rather than for the last modified date? |
@wtgodbe Got it! We'll make note in our test scenario. Thanks much! |
Transfered from from dotnet/runtime#3756.
The text was updated successfully, but these errors were encountered: