Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad handling of complete logout in RemoteAuthenticatorViewCore.ProcessLogOutCallback #34990

Closed
RemiBou opened this issue Aug 3, 2021 · 2 comments
Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly feature-blazor-wasm-auth investigate
Milestone

Comments

@RemiBou
Copy link
Contributor

RemiBou commented Aug 3, 2021

Describe the bug

In Blazor WASM when CompleteSignOutAsync returns RemoteAuthenticationStatus.OperationCompleted:, nothing is done, so the message "Processing logout callback..." is still displayed

To Reproduce

Implement https://auth0.com/blog/securing-blazor-webassembly-apps/

Suggested fix

Merge Success and OperationCompleted switch branch


 case RemoteAuthenticationStatus.OperationCompleted:
case RemoteAuthenticationStatus.Success:
                    await OnLogOutSucceeded.InvokeAsync(result.State);
                    await NavigateToReturnUrl(GetReturnUrl(result.State, Navigation.ToAbsoluteUri(ApplicationPaths.LogOutSucceededPath).ToString()));
                    break;

Further technical details

  • ASP.NET Core version : 5.0.0
@Pilchie Pilchie added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Aug 3, 2021
@blowdart blowdart added the area-blazor Includes: Blazor, Razor Components label Aug 3, 2021
@pranavkm pranavkm added this to the Backlog milestone Aug 5, 2021
@ghost
Copy link

ghost commented Aug 5, 2021

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@Tratcher Tratcher removed the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Oct 28, 2021
@mkArtakMSFT mkArtakMSFT added feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly feature-blazor-wasm-auth labels Oct 21, 2022
@mkArtakMSFT
Copy link
Member

Hi. Thanks for contacting us.
We're closing this issue as there was not much community interest in this ask for quite a while now.
You can learn more about our triage process and how we handle issues by reading our Triage Process writeup.

@mkArtakMSFT mkArtakMSFT closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly feature-blazor-wasm-auth investigate
Projects
None yet
Development

No branches or pull requests

6 participants