Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target net10.0 in RepoTasks #58823

Closed
mthalman opened this issue Nov 6, 2024 · 2 comments · Fixed by #59058
Closed

Target net10.0 in RepoTasks #58823

mthalman opened this issue Nov 6, 2024 · 2 comments · Fixed by #59058
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Comments

@mthalman
Copy link
Member

mthalman commented Nov 6, 2024

The changes made to RepoTasks in https://github.com/dotnet/aspnetcore/pull/58090/files#diff-976f8f3081f5ec8e8aacf560c64825479b33b0953bdc4dec82255c7cbe8d01d9 will need to be reverted. Specifically, net9.0 should be changed back to $(DefaultNetCoreTargetFramework). This can be done once a dependency on a .NET SDK is taken that has these changes: dotnet/sdk#43015.

Related to dotnet/sdk#44685
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 6, 2024
@ViktorHofer
Copy link
Member

@wtgodbe can you please help with this? This involves updating the SDK in this repo to a recent build and reverting the change in RepoTasks.csproj as described above.

@wtgodbe wtgodbe mentioned this issue Nov 19, 2024
Merged
@wtgodbe
Copy link
Member

wtgodbe commented Nov 19, 2024

Sure, we were finally able to upgrade to the net10.0 SDK yesterday - #59058

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Undo RepoTasks workaround dotnet/aspnetcore
3 participants
@ViktorHofer @wtgodbe @mthalman