Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply RID graph for .NET Core 3.0 SDK #9806

Closed
dsplaisted opened this issue Oct 4, 2018 · 4 comments
Closed

Supply RID graph for .NET Core 3.0 SDK #9806

dsplaisted opened this issue Oct 4, 2018 · 4 comments
Milestone

Comments

@dsplaisted
Copy link
Member

Currently, the RuntimeIdentifier graph is provided via the Microsoft.NETCore.Platforms package, which is a dependency of the Microsoft.NETCore.App and NETStandard.Library packages. With .NET Core 3.0, we will be using Targeting Packs instead of these packages. The targeting packs won't support package dependencies, and won't be able to include the runtime graph for NuGet.

So we will need to find a different way of bringing in the RID graph. Two options come to mind:

@dsplaisted
Copy link
Member Author

Related: #1046

@dasMulli
Copy link
Contributor

dasMulli commented Nov 4, 2018

If possible, it would be great to be able to pass the RID graph to .net framework builds as well. preferably in a way that can also be shipped within VS.
Currently, packages relying on native assets aren't always correctly resolved in .net framework builds until a reference to m.nc.platforms is added. This has come up a few times and it would be great to have a "fallback" RID graph that comes with the SDK / VS installation.

@nguerrera
Copy link
Contributor

We're going to split this in two:

  1. For initial bring-up, we will have exactly one version of the graph in the .NET Core SDK.
  2. We need to figure out how to prevent breaking changes. By this we mean that we don't want the assets selected in a build to change with an sdk change and no project change. We thought about versioning it by TFM, but there's just one Platforms package with increasing version for all TFMs.

We'll leave this issue tracking just (1)

@dsplaisted
Copy link
Member Author

We need to figure out how to prevent breaking changes. By this we mean that we don't want the assets selected in a build to change with an sdk change and no project change. We thought about versioning it by TFM, but there's just one Platforms package with increasing version for all TFMs.

This is covered by https://github.com/dotnet/cli/issues/10496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants