Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOS does not know about the pinned object heap #1068

Closed
davmason opened this issue Apr 24, 2020 · 1 comment · Fixed by #1228
Closed

SOS does not know about the pinned object heap #1068

davmason opened this issue Apr 24, 2020 · 1 comment · Fixed by #1228
Labels
Priority:1 Work that is critical for the release, but we could probably ship without sos
Milestone

Comments

@davmason
Copy link
Member

Looking through the code, I can see that DacpGcHeapDetails and GCHeapSnapShot have hardcoded generation limits. Now that the runtime has another heap these APIs will be incomplete.

The following SOS commands use DacpGcHeapDetails:

  • !EEHeap
  • !ListNearObj
  • !GCWhere
  • !GCHeapStat
  • !FinalizeQueue

And these APIs use GCHeapSnapShot:

  • !GCRoot
  • !DumpStackObjects
  • !DumpIL
  • !TraverseHeap
  • !DumpAsync
  • !DumpHeap
  • !VerifyHeap
  • !VerifyObj
  • !FindRoots

I haven't done any testing, but based on my reading of the code none of them should be broken, but they will not report objects out of the pinned object heap.

@sdmaclea sdmaclea added this to the 5.0 milestone Apr 24, 2020
@sdmaclea sdmaclea added the sos label Apr 24, 2020
@tommcdon tommcdon added the Priority:1 Work that is critical for the release, but we could probably ship without label Apr 24, 2020
@leculver
Copy link
Contributor

@tommcdon This should be a ship-blocking issue for .Net Core 5. We really shouldn't ship the runtime if SOS functionality is broken, If you guys are planning to fix it within the next month (or so) I won't bother filing a blocking issue over there.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Priority:1 Work that is critical for the release, but we could probably ship without sos
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants