Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/test updates/migration guidance for new runtime metrics in dotnet-counters #4806

Closed
noahfalk opened this issue Jul 24, 2024 · 3 comments
Assignees
Labels
documentation Documentation related issue dotnet-counters
Milestone

Comments

@noahfalk
Copy link
Member

noahfalk commented Jul 24, 2024

We recently added new runtime metrics based on the Meter API to .NET. Although the previous EventCounter-based runtime metrics are still present, these new metrics are intended to be the long-term path forward. In order to complete the scenario we need to do several followup tasks:

  1. We've got dotnet-counters tests that explicitly validated against the old metric names so we should update those tests. Example ( DotnetCounters.UnitTests.CounterMonitorPayloadTests.TestCounterMonitorSystemRuntimeMetricsCSV).
  2. We need to add docs about the new metrics to our official docs and guidance for anyone migrating.
  3. We should add some mechanism to dotnet-counters for folks to access the previous EventCounter based metrics if they still want to see them.

fyi @tarekgh @stevejgordon @dotnet/dotnet-monitor

@noahfalk noahfalk self-assigned this Jul 24, 2024
@mikem8361
Copy link
Member

TestCounterMonitorSystemRuntimeMetricsJSON and TestCounterMonitorSystemRuntimeMetricsCSV in CounterMonitorPayloadTests.cs need to be re-enabled after the test is fixed for recent 9.0 changes while maintaining backwards compatibility with .NET 6/7/8 .

@tommcdon tommcdon added this to the 9.0.0 milestone Jul 30, 2024
@tommcdon tommcdon added documentation Documentation related issue dotnet-counters labels Jul 30, 2024
@noahfalk
Copy link
Member Author

noahfalk commented Aug 7, 2024

fyi @samsp-msft

@noahfalk
Copy link
Member Author

noahfalk commented Sep 4, 2024

Everything was addressed, PRs linked in the description.

@noahfalk noahfalk closed this as completed Sep 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation related issue dotnet-counters
Projects
None yet
Development

No branches or pull requests

3 participants