Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MSBuild 16 (VS 2019) #4437

Closed
3 tasks done
superyyrrzz opened this issue Apr 28, 2019 · 2 comments · Fixed by #4595
Closed
3 tasks done

Support MSBuild 16 (VS 2019) #4437

superyyrrzz opened this issue Apr 28, 2019 · 2 comments · Fixed by #4595
Assignees
@superyyrrzz

Comments

@superyyrrzz
Copy link
Contributor

superyyrrzz commented Apr 28, 2019 •
edited
Loading

Now users with VS 2019 alone cannot generate site correctly. #2562 (comment)

Work items:

  • Upgrade from net462 to net472
  • Upgrade Microsoft.Build to 16
  • Updrade logic to locate msbuild
@superyyrrzz superyyrrzz added the v2 label Apr 28, 2019
@superyyrrzz superyyrrzz self-assigned this Apr 28, 2019
@superyyrrzz superyyrrzz changed the title Support MSBuild 16 Support MSBuild 16 (VS 2019) Apr 28, 2019
@StephenHodgson
Copy link

StephenHodgson commented May 12, 2019 •
edited
Loading

Biggest difference here is the path after calling vswhere.

The new location is in:

{VisualStudio Install Root}\MSBuild\Current\Bin

versus the old:

{Visual Studio Install Root}\MSBuild\{version}\Bin

@superyyrrzz
Copy link
Contributor Author

@StephenHodgson Sure. Plan to upgrade to latest MSBuildLocator, which handles this difference.

This was referenced May 14, 2019
Merged
Merged
@superyyrrzz superyyrrzz mentioned this issue May 21, 2019
Merged
@superyyrrzz superyyrrzz mentioned this issue Jun 13, 2019
Closed
@mnoreke mnoreke mentioned this issue Jul 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@superyyrrzz superyyrrzz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade msbuild locator to support msbuild 16
2 participants
@superyyrrzz @StephenHodgson