Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change]: RuntimeInformation.OSArchitecture return value under emulation #30894

Closed
1 of 2 tasks
jkotas opened this issue Aug 27, 2022 · 3 comments · Fixed by #31142
Closed
1 of 2 tasks

[Breaking change]: RuntimeInformation.OSArchitecture return value under emulation #30894

jkotas opened this issue Aug 27, 2022 · 3 comments · Fixed by #31142
Assignees
Labels
binary incompatible Existing binaries may encounter a breaking change in behavior. breaking-change Indicates a .NET Core breaking change 🏁 Release: .NET 7 Work items for the .NET 7 release doc-idea Indicates issues that are suggestions for new topics [org][type][category] Pri1 High priority, do before Pri2 and Pri3

Comments

@jkotas
Copy link
Member

jkotas commented Aug 27, 2022

Description

RuntimeInformation.OSArchitecture returned incorrect value under emulation.

Version

.NET 7 Preview 6

Previous behavior

System.Runtime.InteropServices.RuntimeInformation.OSArchitecture returned Architecture.x64 in emulated processes on Windows Arm 64-bit and macOS Apple Silicon systems.

New behavior

System.Runtime.InteropServices.RuntimeInformation.OSArchitecture returns Architecture.Arm64 in emulated processes on Windows Arm 64-bit and macOS Apple Silicon systems.

Type of breaking change

  • Binary incompatible: Existing binaries may encounter a breaking change in behavior, such as failure to load/execute or different run-time behavior.
  • Source incompatible: Source code may encounter a breaking change in behavior when targeting the new runtime/component/SDK, such as compile errors or different run-time behavior.

Reason for change

The previous behavior was incorrect.

Recommended action

Code that expects the process architecture should be changed to call System.Runtime.InteropServices.RuntimeInformation.ProcessArchitecture instead.

Feature area

Interop

Affected APIs

System.Runtime.InteropServices.RuntimeInformation.OSArchitecture

@jkotas jkotas added doc-idea Indicates issues that are suggestions for new topics [org][type][category] breaking-change Indicates a .NET Core breaking change Pri1 High priority, do before Pri2 and Pri3 labels Aug 27, 2022
@dotnet-bot dotnet-bot added 🏁 Release: .NET 7 Work items for the .NET 7 release binary incompatible Existing binaries may encounter a breaking change in behavior. ⌚ Not Triaged Not triaged labels Aug 27, 2022
@hamarb123
Copy link

@jkotas, I know this is the wrong issue, but I just wanted to say that dotnet/runtime#52639 doesn't have a breaking change doc made or in the making afaik, but it is supposed to have one.

@jkotas
Copy link
Member Author

jkotas commented Aug 28, 2022

dotnet/runtime#52639 doesn't have a breaking change doc made or in the making afaik, but it is supposed to have one.

It has needs-breaking-change-doc-created label. Area owners are expected to go over all PRs marked with this label and make sure that the breaking change docs are created.

@danmoseley Is there a dead-line for creating the breaking change docs?

@danmoseley
Copy link
Member

I think @jeffhandley will ask someone to chase them up for the release in a little bit, like last year.

@gewarren gewarren removed the ⌚ Not Triaged Not triaged label Sep 1, 2022
@ghost ghost added the in-pr This issue will be closed (fixed) by an active pull request. label Sep 13, 2022
@ghost ghost removed the in-pr This issue will be closed (fixed) by an active pull request. label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binary incompatible Existing binaries may encounter a breaking change in behavior. breaking-change Indicates a .NET Core breaking change 🏁 Release: .NET 7 Work items for the .NET 7 release doc-idea Indicates issues that are suggestions for new topics [org][type][category] Pri1 High priority, do before Pri2 and Pri3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants