Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable storing of secrets into Credential Manager/Keychain #10

Closed
wiktork opened this issue Nov 18, 2020 · 2 comments
Closed

Enable storing of secrets into Credential Manager/Keychain #10

wiktork opened this issue Nov 18, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone
Future

Comments

@wiktork
Copy link
Member

wiktork commented Nov 18, 2020

The token would be generated by dotnet/diagnostics#1747
@hoyosjs hoyosjs transferred this issue from dotnet/diagnostics Feb 16, 2021
@jander-msft jander-msft added this to the Future milestone Mar 16, 2021
@jander-msft jander-msft added the enhancement New feature or request label Apr 20, 2021
@wiktork wiktork changed the title Enable storing of generated token into Credential Manager/Keychain Enable storing of secrets into Credential Manager/Keychain Mar 1, 2022
@wiktork
Copy link
Member Author

wiktork commented Mar 1, 2022

The api key no longer needs to be stored, but we may want to store Azure keys into Credential Manager.

@jander-msft
Copy link
Member

Storage of keys that are provided by the user who configures the .NET Monitor tool is outside of the scope of the tool itself. If there is a compelling scenario by which the .NET Monitor tool should load keys from storage locations outside of what is available at this time, a new issue should be logged to describe it.

@jander-msft jander-msft closed this as not planned Won't fix, can't repro, duplicate, stale Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@wiktork @jander-msft