Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid performing work in StateManager.ResetState if not needed #24770

Open
roji opened this issue Apr 26, 2021 · 0 comments
Open

Avoid performing work in StateManager.ResetState if not needed #24770

roji opened this issue Apr 26, 2021 · 0 comments

Comments

@roji
Copy link
Member

roji commented Apr 26, 2021

Commenting out StateManager.ResetState provides a 0.6% perf increase in Techempower Fortunes (#23611). We can check whether the clearing/unregistering activities there are actually needed.

Note #24769 which is about an opt-in to disable resetting altogether. Unlike that issue, this one would speed things up for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants