-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging error: Invalid nuget package with 2 identical files created #2744
Comments
I've confirmed by checking out tag
you'll see 2 x |
There are multiple packages in the 3.1 release cycle witu this issue. It seems to be a systematic issue somewhere in packaging. |
From internal email thread: Md paket-2019-12-break Modify project file to be:
Dotnet pack actual behavior: only one packageicon.jpg entry (as viewed via 7-zip) would love to understand if we (nuget client) have an issue to address here. |
@rrelyea we got into this situation in two steps
@wtgodbe didn't you fix all of our repos up to use only the Arcade SDK logic? Did merges forward into our 3.1 branches just miss the boat on the GA release? |
@dougbu I did fix this, but it didn't get merged forward for 3.1.0. The fixes are in 3.1.1 and master now, though. |
Given that 3.1.0 package already shipped. We need to understand if having a 3.1.1 package with the fix will help fix the issue for most people. If they pick it because it is hardcoded into a template, then the fix won't be too helpful. We also should understand which scenarios are hurt by it. Just Paket? Other? Paket? all Versions? How often do paket users upgrade to latest, etc... - @forki and team can likely help us understand impact of their user base and importance of fixed packages - now or in about a month? |
From Paket perspective: workaround is applied and a new Paket version is available. Usually this means the problem is gone next day because our user base is mostly running on the latest Paket. So if the problem is identified by MS then I don't think 3.1.1 packages are really needed to be pushed immediately. At least not from our perspective. But I think nuget team should add an additional check for duplicates in package verification. This would prevent similar issues in the future |
By the way, if somebody is using a nuspec, it is possible to have duplicate items in a nupkg: NuGet/Home#6941 |
I would prefer 3.1.1 versions of affected packages ASAP as this issue block us from pushing them to private NuGet server. The server is returning status 406 (not accepted). |
@Fido789 which private NuGet server implementation do you use? |
@forki I have tried it with https://www.nuget.org/packages/NuGet.Server/3.1.2 and https://www.nuget.org/packages/NuGet.Server/3.4.1 |
Wow. So private installation of nuget is rejecting the packages but the public server did not? |
NuGetGallery and NuGet.Server are two different codebases. Not surprising that their behavior differs a bit here. @joelverhagen |
@Pilchie Should this issue be triaged into a milestone and assigned to someone so that people can track the status? |
If nuget's own private server implementation is rejecting the packages and Paket did, then chances are other 3rd-party servers and tools will do as well. |
I believe this is already fixed in |
@Pilchie that's correct, this is fixed for 3.1.1. |
@Pilchie are those packages already available? Will the broken ones be unlisted? And then there is the problem of nuget's behavior with unlisted packages. If it's a transitive dependency then nuget will continue to install 3.1.0 because of it's minimum matching version resolver. Even if that package is unlisted. |
No, the packages are not available yet, we're still working through issues with preparing 3.1.1 all-up. I don't expect they will be released before the new year unfortunately. |
But why can't you push a wave of packages that just fix this specific issue? As more and more people are moving to 3.1 this will be getting more serious. |
That's just not the way our infrastructure is set up unfortunately. |
Any news on this or an eta for release? I'm allergic to build warnings when restoring packages |
The next patch release (3.1.1) includes a fix for this issue. We're working to get that release out soon. |
Verbose: File system changed. File: microsoft.extensions.configuration.3.1.0.nupkg - Change: Changed |
Describe the bug
See fsprojects/Paket#3743 - Currently one or many projects that were pushed in the last 24hrs seem to have lliegal content in the ZIP file, creating issues with compression libs. Specifically, the packaged icon is duplicated. See screenshot
To Reproduce
Screenshots
Additional context
While the paket guys implemented a fix for that, this should be investigated thoroughly, as it seems to hit multiple packaging jobs not connected to the same namespace.
The text was updated successfully, but these errors were encountered: