FakeTimeProvider does not support creating a CancellationTokenSource with an infinite delay

[martincostello]

Description

If code creates a CancellationTokenSource with an infinite delay, when that code is invoked with FakeTimeProvider instead of TimeProvider.System an ArgumentOutOfRangeException is thrown.

Reproduction Steps

Execute the following xunit test targeting net8.0:

using Microsoft.Extensions.Time.Testing;

namespace FakeTimeProviderIssueRepro;

public static class FakeTimeProviderTests
{
    public static IEnumerable<object[]> TimeProviders => new[]
    {
        new[] { TimeProvider.System },
        new[] { new FakeTimeProvider() },
    };

    [Theory]
    [MemberData(nameof(TimeProviders))]
    public static void Can_Create_Infinite_CancellationTokenSource_With_TimeProvider(TimeProvider timeProvider)
    {
        using var cts = new CancellationTokenSource(Timeout.InfiniteTimeSpan, timeProvider);
        cts.IsCancellationRequested.ShouldBeFalse();
    }
}

Expected behavior

Both tests pass.

Actual behavior

The test using FakeTimeProvider fails with the following exception:

Can_Create_Infinite_CancellationTokenSource_With_TimeProvider(timeProvider: 2000-01-01T00:00:00.000) 

Duration: 2 ms

Message: 
  System.ArgumentOutOfRangeException : Argument not in the range [-1..4294967294] (Parameter 'dueTime')
  Actual value was 4294967295.

Stack Trace: 
  Throw.ArgumentOutOfRangeException(String paramName, Object actualValue, String message)
  Waiter.ChangeAndValidateDurations(TimeSpan dueTime, TimeSpan period)
  Waiter.ctor(FakeTimeProvider fakeTimeProvider, TimeSpan dueTime, TimeSpan period, TimerCallback callback, Object state)
  FakeTimeProviderTimer.ctor(FakeTimeProvider fakeTimeProvider, TimeSpan dueTime, TimeSpan period, TimerCallback callback, Object state)
  FakeTimeProvider.CreateTimer(TimerCallback callback, Object state, TimeSpan dueTime, TimeSpan period)
  CancellationTokenSource.InitializeWithTimer(UInt32 millisecondsDelay, TimeProvider timeProvider)
  CancellationTokenSource.ctor(TimeSpan delay, TimeProvider timeProvider)
  FakeTimeProviderTests.Can_Create_Infinite_CancellationTokenSource_With_TimeProvider(TimeProvider timeProvider) line 20
  InvokeStub_FakeTimeProviderTests.Can_Create_Infinite_CancellationTokenSource_With_TimeProvider(Object, Object, IntPtr*)
  MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

Regression?

No.

Known Workarounds

None.

Configuration

• .NET SDK 8.0.100-preview.5.23303.2
• Microsoft.Extensions.TimeProvider.Testing 8.0.0-preview.5.23308.3

Other information

No response

[martincostello]

Digging into the code, I think this is actually an issue in dotnet/runtime caused by the cast to uint in this method. Just verifying and if so will open a new issue there and close this one.

[martincostello]

dotnet/runtime#88000