Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage issues #4124

Open
martintmk opened this issue Jun 27, 2023 · 3 comments
Open

Code coverage issues #4124

martintmk opened this issue Jun 27, 2023 · 3 comments
Assignees

Comments

@martintmk
Copy link
Contributor

Description

In the PR #4108 I had to decrease the code-coverage from 100% to 98% because the build pipeline handles the code-coverage processing incorrectly.

The following lines:

public static IHttpResilienceStrategyBuilder AddResilienceHandler(

are correctly covered and tested, but the build fails.

There are also additional inconsistencies:

Reproduction Steps

Increase the min coverage to 100, the build fails:

Expected behavior

Increase the min coverage to 100, the build should succeed:

Actual behavior

The build fails when increasing the code-coverage to 100

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

Please

@RussKie
Copy link
Member

RussKie commented Jun 28, 2023

As per recommendation we need to use PublishCodeCoverageResults@2 task. However, that task is currently broken.
I was advised the fix is in the pipeline, however, I'm yet to get clearer information on when the fix will be public.

/cc: @vinayakmsft

@RussKie RussKie removed the untriaged label Jun 28, 2023
@RussKie RussKie self-assigned this Jun 28, 2023
@RussKie
Copy link
Member

RussKie commented Jun 29, 2023

@vinayakmsft advised me yesterday that it may be few weeks before the fix will be rolled out. In the interim as a workaround we can run the task on Windows agents and install .NET 7.

@geeknoid
Copy link
Member

Is this fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants