Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbols: local functions don't provide parameter names and declaring type info #13381

Closed
auduchinok opened this issue Jun 24, 2022 · 4 comments
Closed
Assignees

Comments

@auduchinok
Copy link
Member

auduchinok commented Jun 24, 2022

Consider 3 function declarations:

let a x = ()

type T() =
    let b x = ()

do
    let c x = ()
    ()

a provides info about its parameters:

Screenshot 2022-06-24 at 19 24 58

b and c don't:

Screenshot 2022-06-24 at 19 26 14

Without this info it's problematic to provide rich tooling experience, as the features like Parameter Info popup need the parameter names. In addition to that, b doesn't provide its declaring entity.

The apparent difference between a and b or c is that the latter don't return any data from their TypedTree.ValRef.ValReprInfo properties. The data seems to be kept somewhere, as (at least) b has its parameter name compiled.

@dsyme Do you have an idea of how the missing data could be added?

@auduchinok auduchinok added the Bug label Jun 24, 2022
@auduchinok
Copy link
Member Author

It looks like #13061 is caused by the same problem, though this issue is about the missing parameter data, and the other one sounds like it's about the presentation improvement (since parameter can indeed not have a name, and backticks aren't good there).

@kerams
Copy link
Contributor

kerams commented Jun 24, 2022

A dupe of #7080.

@psfinaki
Copy link
Member

@auduchinok @kerams thanks for your investigations! Will take this as well.

@psfinaki psfinaki self-assigned this Jun 27, 2022
@psfinaki
Copy link
Member

But will assign the other one then, closing this as a dupe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants