Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockstructure lines are a bit weird #2115

Open
forki opened this issue Dec 27, 2016 · 12 comments
Open

Blockstructure lines are a bit weird #2115

forki opened this issue Dec 27, 2016 · 12 comments
Labels
Area-LangService-BlockStructure those block structure lines and the FCS API that produces them Bug Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Milestone

Comments

@forki
Copy link
Contributor

forki commented Dec 27, 2016

image

/cc @cloudRoutine

@forki
Copy link
Contributor Author

forki commented Dec 28, 2016

image

why is this first line shown. we already have a solid line over there

@saul
Copy link
Contributor

saul commented Dec 29, 2016

Here's two more:

  1. Class where the constructor arguments are on a new line.
  2. Computation expressions. The guide line seems to start at the opening brace.

sketch 21

@saul
Copy link
Contributor

saul commented Dec 29, 2016

/cc @vasily-kirichenko as you did some fixes for the block structuring recently.

@vasily-kirichenko
Copy link
Contributor

@saul that was not me, that was @cloudRoutine (and he is the original author of all the code ported from VFPT).

@saul
Copy link
Contributor

saul commented Dec 29, 2016

Sorry - wasn't implying that you broke it - just that you may know of the fix :)

@cartermp cartermp added Area-LangService-API Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. labels Dec 29, 2016
@cartermp
Copy link
Contributor

Classifying this set of bugs as urgency-soon. Although it certainly doesn't break people, some of the above things look weird enough to justify trying to get this in for release.

@cartermp
Copy link
Contributor

If we can't get some of these fixes in for release, we should definitely discuss turning the feature off.

@vasily-kirichenko
Copy link
Contributor

@saul are you sure you test the latest version from master? I cannot reproduce you issues:

1

@saul
Copy link
Contributor

saul commented Dec 29, 2016

Definitely not on latest master - I've been refraining from updating over the past few days because of #1825

If you can't reproduce on master then please ignore my comment. I can consistently reproduce it on every computation expression.

@vasily-kirichenko
Copy link
Contributor

FYI

It turns out, there is a global setting which turns on / off guidelines (not block collapsing, but just guidelines):

image

So annoyed people will be able to turn it off.

@saul
Copy link
Contributor

saul commented Jan 8, 2017

Vasily have you any idea why the extra guidelines are shown for multi-line pattern match cases? My issue that was closed as dupe has a minimal repro: #2191

@cartermp
Copy link
Contributor

cartermp commented Jan 20, 2017

I just noticed the same issue as Saul for parameters on the same line, but this time on a static member.

structure-guidelines-weird

This is the first line I noticed: https://github.com/bryanedds/Nu/blob/master/Nu/Nu/Render.fs#L206

But it happens multiple places in that file.

@cartermp cartermp modified the milestones: VS 2017 Updates, 16.0 Jun 20, 2018
@cartermp cartermp modified the milestones: 16.0, 16.1 Feb 21, 2019
@cartermp cartermp modified the milestones: 16.1, 16.2 Apr 23, 2019
@cartermp cartermp modified the milestones: 16.2, Backlog Apr 30, 2019
@cartermp cartermp removed the Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. label Jul 10, 2020
@dsyme dsyme added the Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. label Aug 26, 2020
@cartermp cartermp removed this from the Backlog - Lower Priority milestone Oct 28, 2020
@cartermp cartermp added this to the Backlog milestone Oct 28, 2020
@dsyme dsyme added Area-LangService-BlockStructure those block structure lines and the FCS API that produces them and removed Area-LangService-API labels Apr 5, 2022
@vzarytovskii vzarytovskii reopened this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-LangService-BlockStructure those block structure lines and the FCS API that produces them Bug Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Projects
Archived in project
Development

No branches or pull requests

7 participants