Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant .resx files when updated dotnet ships. #3905

Closed
brettfo opened this issue Nov 7, 2017 · 7 comments
Closed

Remove redundant .resx files when updated dotnet ships. #3905

brettfo opened this issue Nov 7, 2017 · 7 comments
Assignees
Milestone

Comments

@brettfo
Copy link
Member

brettfo commented Nov 7, 2017

PR #3904 required that some .resx files be added to the src/buildfromsource/ directory. When a new dotnet sdk is shipped that has changes #3577 and #3607, then the .resx files (and their accompanying .fs files) should be removed.

@brettfo brettfo self-assigned this Nov 7, 2017
@dsyme
Copy link
Contributor

dsyme commented Dec 1, 2017

+100

@cartermp
Copy link
Contributor

@brettfo Does this still need to be open?

@brettfo
Copy link
Member Author

brettfo commented Feb 15, 2018

There are still some we need to keep around for the proto build and buildfromsource, so it should stay open a bit longer.

@TD5
Copy link
Contributor

TD5 commented Oct 10, 2018

Does resolving this issue remove the need to manually copy any files at all across to src\buildfromsource\FSharp.Compiler.Private\ (as per DEVGUIDE.md)?

@brettfo
Copy link
Member Author

brettfo commented Oct 10, 2018

Yes, once this is resolved that manual copy step will go away. It should be handled by my changes in #5842.

@cartermp
Copy link
Contributor

@brettfo Now that we have an updated SDK we build against, can these files be removed?

@cartermp cartermp added this to the Unknown milestone Jan 30, 2019
@cartermp cartermp modified the milestones: Unknown / not bug, 16.1 May 1, 2019
@cartermp
Copy link
Contributor

cartermp commented May 1, 2019

Closing this as we no longer have this directory in our source build.

@cartermp cartermp closed this as completed May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants