Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion performance for multitargeted projects is slow #4914

Closed
cartermp opened this issue May 15, 2018 · 2 comments
Closed

Completion performance for multitargeted projects is slow #4914

cartermp opened this issue May 15, 2018 · 2 comments
Labels
Area-LangService-API Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Milestone

Comments

@cartermp
Copy link
Contributor

With SDK-style projects, if you multi-target, the experience is subpar due to very slow completion. With #4889 this is alleviated for a time, but after a while it will still invalidate caches and rebuild chunks of the world. The language service itself needs to properly understand the additional context that multitargeting requires.

Although this is not a regression, it is still quite a bad experience for people who multitarget. We recommend sticking to a single target if you don't require multitargeting.

@cartermp cartermp added Tenet-Performance Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. Area-LangService-API labels May 15, 2018
@cartermp cartermp added this to the 15.8 milestone May 15, 2018
@TIHan
Copy link
Contributor

TIHan commented May 15, 2018

This should help it even more: #4918

We will still type check multiple times, once per TFM; that is what Roslyn does. But, entire swaths of cache will not be invalidated anymore.

I tested this myself and now multi-targeting is much much better. Especially in Area51's case.

@TIHan
Copy link
Contributor

TIHan commented May 16, 2018

This is now resolved.

@TIHan TIHan closed this as completed May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-LangService-API Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Projects
None yet
Development

No branches or pull requests

2 participants