Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge allocation in PrettyNaming.splitAroundQuotations #5939

Closed
vasily-kirichenko opened this issue Nov 20, 2018 · 2 comments
Closed

Huge allocation in PrettyNaming.splitAroundQuotations #5939

vasily-kirichenko opened this issue Nov 20, 2018 · 2 comments

Comments

@vasily-kirichenko
Copy link
Contributor

Editing a file containing an XmlProvider declaration, for about 20 seconds:

image

image

image

AFAIK, the problem is here:

https://github.com/Microsoft/visualfsharp/blob/44c7e10ca432d8f245a6d8f8e0ec19ca8c72edaf/src/fsharp/PrettyNaming.fs#L585

As a result, there were several seconds freezes in Rider while typing.

@cartermp
Copy link
Contributor

#5599 reduces split allocations by an order of magnitude, but I'm not sure if this went into a given VS release and corresponding FCS release. You can verify if this helps rider by using a build of FCS from this repo.

@vasily-kirichenko
Copy link
Contributor Author

@cartermp thank you! I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants