-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run more tests in temporary directory #17683
Conversation
✅ No release notes required |
@majocha - This looks good, is it ready for review, or will you do the Big Todo in this PR? |
@KevinRansom if it's ok I'd rather not, because frankly I have no idea how to even approach it :) |
SDKTests does not seem to produce any artifacts, so it can safely run in-place. |
Yes, I have also checked this. So theoretically migrating it to the new platform shouldn't be a problem? It uses this |
My guess is we can just modify the files to use a custom prop instead of $MSBuildThisFileDirectory and pass the correct path in code via "-property:" but it does not seem to be needed at all right now. |
Yeah, that's my feeling as well. Shall we once again try to remove |
Let's try it for completness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alrighty, so that's a progress, let's get this in! Thanks @majocha :)
(just in case, I checked the number of tests being run in the PR, all good :D)
Some tests cases were executing in this repo subfolders, often many tests reusing the same folders. This had disadvantages.
You can't run such tests cases concurrently and sometimes git changes get polluted with test artifacts.
The idea is to simply copy the directory required by the test, with subfolders, to temp.
On each test run a subfolder is created in
%TEMP%/FSharp.Test.Utilities/
named with current date and a short uinque id:%TEMP%/FSharp.Test.Utilities/yyy-MM-dd-xxxxxxx/
.Test cases executed during the test run create separate uniquely named folders inside.
This PR is extracted from the experiments in test parallelization.